Skip to content

Fix block editor crash when editor.MediaUpload is a functional component #8169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saroshaga wants to merge 1 commit into
base: develop
Choose a base branch
from
+11 −0
Open

Fix block editor crash when editor.MediaUpload is a functional component #8169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions assets/src/block-editor/components/with-media-library-notice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,17 @@ export default (InitialMediaUpload, minImageDimensions) => {
});
};

// If the component is not a class (e.g. a functional or arrow function component
// returned by another plugin's filter), it cannot be extended via `class extends`.
// In that case, return it as-is to avoid crashing the editor with:
// "TypeError: Class extends value ... is not a constructor or null"
if (
!InitialMediaUpload.prototype ||
!InitialMediaUpload.prototype.isReactComponent
) {
return InitialMediaUpload;
}

/**
* Extends the MediaUpload component to display a notice for small images.
*/
Expand Down
Loading