Fix cppcheck [useInitializationList] warnings#191
Fix cppcheck [useInitializationList] warnings#191sc0w wants to merge 1 commit intoamule-project:masterfrom
Conversation
|
I don't understand you, this PR isn't related to #190, please review here this PR. |
|
In short, the problem is: you're fixing warnings not code. Some examples:
If you're already using cppcheck, there are more severe issues in the code.... (just a hint). If I were you I would certainly open a branch and commit there all the changes required by cppcheck, all the changes that were made on the way to fix bugs you encounter meanwhile. And maybe create a configuration file for cppcheck to prevent false positives. And, while we're already at it, use meaningful commit messages, describing what and why you change. |
No description provided.