modernize a little autotools

[sergiomb2]

Since aMule are about to have a new version, here is my contribution , autopoint may be replace by a newer intltool, is a more elegant solution .

[gonosztopi]

The empty files your patch adds are already there in the docs subdir - and should stay there. That's why we have the --foreign switch on automake.

[sergiomb2]

I had use intltool-update to update po files , use relative paths , but still not fix the issue and using IT_PROG_INTLTOOL we don't have translation and back to AM_GNU_GETTEXT we have translation, anyway we have some improves ...

[gonosztopi]

I still have complaints... :-)

Change of all source references in translation files - should be done in a separate commit.
Changing "don't" to "dont" - not accepted.
Now where is the 'intl' subdirectory, needed on systems not having GNU gettext?

[sergiomb2]

Changing "don't" to "dont" - not accepted.

The single quotes doesn't break yours syntax highlighting ? can I use "do not" ?

[gonosztopi]

The single quotes doesn't break yours syntax highlighting ? can I use "do not" ?

No, not mine :-) Anyway, I'd rather have a broken syntax highlighting than syntactically wrong messages to the user.

[sergiomb2]

can I use "do not" ?

[sergiomb2]

 AM_GNU_GETTEXT_VERSION(0.11.5)
+AM_GNU_GETTEXT([external])
+#IT_PROG_INTLTOOL
+#GETTEXT_PACKAGE="amule"
+#AC_SUBST(GETTEXT_PACKAGE)
+#AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE,"$GETTEXT_PACKAGE",[Translation domain used])

if I use IT_PROG_INTLTOOL and next commands instead AM_GNU_GETTEXT (that is what I want to do ) , it compiles and builds .
But if I use GETTEXT_PACKAGE="AC_PACKAGE_NAME" , find_lang requires use aMule with capital M
if I use GETTEXT_PACKAGE="amule" find_lang amule doesn't complains and in both cases , applications translations doesn't work , have any idea what might be ?
Thanks

[sergiomb2]

Any news?

I think is finish , you got the final PR , after some rounds we just run "autoreconf --install" in autogen.sh , autoreconf will run autopoint, and others autos and will not produce any warning.

TIL that is intltool that is deprecated not gettext , now I have revert intltoollize in others projects 😃

[sergiomb2]

OK I finished this review , gettext works perfectly , only thing I'm not sure is if you shouldn't move License
ChangeLog , AUTHORS etc to the root directory , seems that is a rule of autotools ...
Best regards,

subdir-objects option to AM_INIT_AUTOMAKE is potentially dangerous and should not be used.

so we still got a lot of warnings

OK instead I added subdir-objects which almost clean all warnings ..

[sergiomb2]

only thing I'm not sure is if you shouldn't move License
ChangeLog , AUTHORS etc to the root directory , seems that is a rule of autotools ...

I just found in other project that we may use symbol links ...

[sergiomb2]

even more simplified , 3 commits only with deleted files, one commit [1] with modified code

[1]
8f5d145

[sergiomb2]

ping only 8f5d145 have code , the other 3 commit is just deleting files
and renamed: m4/nls.m4 -> m4/mulenfs.m4

[sergiomb2]

rebased with upstream/master and fixed the divergences