-
Notifications
You must be signed in to change notification settings - Fork 27
Convert the :sample app to Metro
#173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 0 additions & 18 deletions
18
...oidInstrumentedTest/kotlin/software/amazon/app/platform/sample/TestAndroidAppComponent.kt
This file was deleted.
Oops, something went wrong.
24 changes: 24 additions & 0 deletions
24
...androidInstrumentedTest/kotlin/software/amazon/app/platform/sample/TestAndroidAppGraph.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package software.amazon.app.platform.sample | ||
|
|
||
| import android.app.Application | ||
| import dev.zacsweers.metro.AppScope | ||
| import dev.zacsweers.metro.DependencyGraph | ||
| import dev.zacsweers.metro.Provides | ||
| import software.amazon.app.platform.scope.RootScopeProvider | ||
|
|
||
| /** Metro graph that is used in instrumented tests. */ | ||
| @DependencyGraph(AppScope::class) | ||
| interface TestAndroidAppGraph { | ||
| /** The factory to create a new instance of [AndroidAppGraph]. */ | ||
| @DependencyGraph.Factory | ||
| fun interface Factory { | ||
| /** | ||
| * Creates a new [AndroidAppGraph] instance. [application] and [rootScopeProvider] are provided | ||
| * in the [AndroidAppGraph] and can be injected. | ||
| */ | ||
| fun create( | ||
| @Provides application: Application, | ||
| @Provides rootScopeProvider: RootScopeProvider, | ||
| ): TestAndroidAppGraph | ||
| } | ||
| } |
6 changes: 4 additions & 2 deletions
6
...roidInstrumentedTest/kotlin/software/amazon/app/platform/sample/TestAndroidApplication.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
| package software.amazon.app.platform.sample | ||
|
|
||
| import dev.zacsweers.metro.createGraphFactory | ||
|
|
||
| /** | ||
| * Application class that is used in instrumented tests. Note that it provides a | ||
| * [TestAndroidApplication] instead of [AndroidApplication]. | ||
| */ | ||
| class TestAndroidApplication : AndroidApplication() { | ||
| override fun component(demoApplication: DemoApplication): AppComponent { | ||
| return TestAndroidAppComponent::class.create(this, demoApplication) | ||
| override fun metroGraph(demoApplication: DemoApplication): AppGraph { | ||
| return createGraphFactory<TestAndroidAppGraph.Factory>().create(this, demoApplication) | ||
| } | ||
| } |
23 changes: 0 additions & 23 deletions
23
sample/app/src/androidMain/kotlin/software/amazon/app/platform/sample/AndroidAppComponent.kt
This file was deleted.
Oops, something went wrong.
29 changes: 29 additions & 0 deletions
29
sample/app/src/androidMain/kotlin/software/amazon/app/platform/sample/AndroidAppGraph.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package software.amazon.app.platform.sample | ||
|
|
||
| import android.app.Application | ||
| import dev.zacsweers.metro.AppScope | ||
| import dev.zacsweers.metro.DependencyGraph | ||
| import dev.zacsweers.metro.Provides | ||
| import software.amazon.app.platform.scope.RootScopeProvider | ||
|
|
||
| /** | ||
| * The final Android app graph. | ||
| * | ||
| * Note that [Application] is an Android specific type and classes living in the Android source | ||
| * folder can therefore inject [Application]. | ||
| */ | ||
| @DependencyGraph(AppScope::class) | ||
| interface AndroidAppGraph { | ||
| /** The factory to create a new instance of [AndroidAppGraph]. */ | ||
| @DependencyGraph.Factory | ||
| fun interface Factory { | ||
| /** | ||
| * Creates a new [AndroidAppGraph] instance. [application] and [rootScopeProvider] are provided | ||
| * in the [AndroidAppGraph] and can be injected. | ||
| */ | ||
| fun create( | ||
| @Provides application: Application, | ||
| @Provides rootScopeProvider: RootScopeProvider, | ||
| ): AndroidAppGraph | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 0 additions & 31 deletions
31
sample/app/src/commonMain/kotlin/software/amazon/app/platform/sample/AppComponent.kt
This file was deleted.
Oops, something went wrong.
21 changes: 21 additions & 0 deletions
21
sample/app/src/commonMain/kotlin/software/amazon/app/platform/sample/AppGraph.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package software.amazon.app.platform.sample | ||
|
|
||
| import dev.zacsweers.metro.AppScope | ||
| import dev.zacsweers.metro.ContributesTo | ||
| import dev.zacsweers.metro.ForScope | ||
| import dev.zacsweers.metro.Multibinds | ||
| import software.amazon.app.platform.scope.Scoped | ||
| import software.amazon.app.platform.scope.coroutine.CoroutineScopeScoped | ||
|
|
||
| /** | ||
| * Shared interface for the app graph. The final graphs live in the platform specific source folders | ||
| * in order to have access to platform specific code. | ||
| */ | ||
| @ContributesTo(AppScope::class) | ||
| interface AppGraph { | ||
| /** All [Scoped] instances part of the app scope. */ | ||
| @ForScope(AppScope::class) @Multibinds(allowEmpty = true) val appScopedInstances: Set<Scoped> | ||
|
|
||
| /** The coroutine scope that runs as long as the app scope is alive. */ | ||
| @ForScope(AppScope::class) val appScopeCoroutineScopeScoped: CoroutineScopeScoped | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in "app", can fix it later as well