Conversation
… "removeAll(collection)"
Collections was imported for swap remove, before realizing swapping wasnt needed and copying would suffice.
…loop
I'm not sure that "for (sel : selected) { for (el : elements) { for (elm : elements) { /* only acknowledging sel and elm*/ } } }" makes sense. Perhaps at some point in development, the "sel.intersects(el)" may have been mistaken for a bulk test of all the elements?
The way it was written prior to this commit, it would check all elements for all elements, turning an O(n^2) operation into an O(n^3) operation with n:1 duplicate operations (if I am understanding the intent of the code correctly).
|
Apologies for my IDE removing all the trailing whitespace in the files I edited, I didn't notice it had done that until creating this PR. Also, feel free to remove (or ask me to remove, if that's easier) the edits to the |
|
This is an OLD project initially created by Dr. Poplawski at Michigan
Technological University. I'll need to ask you for proof that this
submission isn't AI and your interest in the project. More contemporary
and industry accepted work builds on Verilog or SystemC.
…On Sun, Feb 8, 2026, 4:42 PM Amy Wilder ***@***.***> wrote:
*AmityWilder* left a comment (anadon/JLS#4)
<#4 (comment)>
Apologies for my IDE removing all the trailing whitespace in the files I
edited, I didn't notice it had done that until creating this PR.
Also, feel free to remove (or ask me to remove, if that's easier) the
edits to the README.md; I understand that may be out of scope for this.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXYEBICEGK7LQNAHUCGWDL4K6UUFAVCNFSM6AAAAACUNDL64GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNRYGM2TCNJZHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
My Computer Organization and Algorithm Engineering professor, Dr. Lalejini, put me in contact with Dr. Kurmas over email after I offered to look into the collision performance. JLS was running rather slowly when I tried building a 16-bit adder without using subcircuits. I promise I did not use AI (I personally hate the stuff and 100% understand your apprehension), but I don't exactly have a 5hr recording of myself writing the code. How would you like me to prove this wasn't AI generated? I can explain every change and every step of my process in depth if that would work. |
|
Saying so is good enough for me. Glad to know my archival work of this
program wasn't for naught. I'll get to reviewing the PR tonight.
…On Mon, Feb 9, 2026 at 10:09 AM Amy Wilder ***@***.***> wrote:
*AmityWilder* left a comment (anadon/JLS#4)
<#4 (comment)>
My Computer Organization and Algorithm Engineering professor, Dr.
Lalejini, put me in contact with Dr. Kurmas over email after I offered to
look into the collision performance. JLS was running rather slowly when I
tried building a 16-bit adder without using subcircuits.
I promise I did not use AI (I personally hate the stuff and 100%
understand your apprehension), but I don't exactly have a 5hr recording of
myself writing the code. How would you like me to prove this wasn't AI
generated? I can explain every change and every step of my process in depth
if that would work.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXYEBMYGIRKHJQGNWDCCW34LCPMJAVCNFSM6AAAAACUNDL64GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNZSGE3DGMJUHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
@anadon FWIW, I created a fork of your work, made some updates, and continue to use JLS in classes (https://github.com/bsiever/JLS/) --- your work definitely wasn't for naught! |
Sets to temporary arrays andArrayLists, since they will be iterated over far more than they will be searched within theoverlapmethod.ArrayListbefore any further checks.i.e.
Related to #3