Fix saving to opened files #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
You're doing great work. I'm sorry I can't keep up right now!
…On Tue, Feb 10, 2026, 4:04 PM Amy Wilder ***@***.***> wrote:
Files that have been opened cannot be saved; only new files. The reason
for this appears to be that the dir field is not assigned when opening a
circuit from a file, and thus no directory path is prepended to the
filename at save, causing the path to be relative to the root, which is
inaccessible (or at least not the location of the actual file).
------------------------------
You can view, comment on, or merge this pull request online at:
#5
Commit Summary
- d92c34c
<d92c34c>
Remove duplicate, unconditional "input.close()"s
- e5f5bd9
<e5f5bd9>
Add makefile for easier compiling and cleanup gitignore
- 1cc8831
<1cc8831>
Add exception message to error dialog
- 30f1902
<30f1902>
Assign directory path to loaded circuits
File Changes
(4 files <https://github.com/anadon/JLS/pull/5/files>)
- *M* .gitignore
<https://github.com/anadon/JLS/pull/5/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947>
(7)
- *A* Makefile
<https://github.com/anadon/JLS/pull/5/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52>
(7)
- *M* src/jls/JLSStart.java
<https://github.com/anadon/JLS/pull/5/files#diff-1eddb4bdb01a90dbe23d50aa664d81fb19ffcbc2d9ae3c4ca39e4989a708bf8a>
(7)
- *M* src/jls/edit/Editor.java
<https://github.com/anadon/JLS/pull/5/files#diff-4c828f1b2a88f49980764b8f7735459b7c0eb521885d70906ffeda44524bbcad>
(2)
Patch Links:
- https://github.com/anadon/JLS/pull/5.patch
- https://github.com/anadon/JLS/pull/5.diff
—
Reply to this email directly, view it on GitHub
<#5>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXYEBIWQ2IHJKGJ6ISLZYT4LJBUBAVCNFSM6AAAAACUVLGFD6VHI2DSMVQWIX3LMV43ASLTON2WKOZTHEZDGNJWGEYTCNI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files that have been opened cannot be saved; only new files. The reason for this appears to be that the
dirfield is not assigned when opening a circuit from a file, and thus no directory path is prepended to the filename at save, causing the path to be relative to the root, which is inaccessible (or at least not the location of the actual file).