Skip to content

Add a new workflow to ensure that new contributions are correctly typed#129

Closed
moi90 wants to merge 1 commit intoanalogdevicesinc:masterfrom
moi90:typing-workflow
Closed

Add a new workflow to ensure that new contributions are correctly typed#129
moi90 wants to merge 1 commit intoanalogdevicesinc:masterfrom
moi90:typing-workflow

Conversation

@moi90
Copy link
Contributor

@moi90 moi90 commented May 23, 2025

(This is a spin-off of #127.)

@trinamic-bp
Copy link
Contributor

While we appreciate the idea of automated checks on pull requests, we are hesitant to rely on a relatively unknown GitHub Action.
The inline annotations produced by Reviewdog are a nice feature, but a simple green/red status output with detailed logs should be sufficient for our needs.

We will work on reducing the current issues flagged by static code analysis tools, and then introduce very plain and simple workflows to check pull requests.

@moi90
Copy link
Contributor Author

moi90 commented Jun 14, 2025

Ok :)

@moi90 moi90 closed this Jun 14, 2025
@moi90
Copy link
Contributor Author

moi90 commented Jun 14, 2025

I chose reviewdog, because it only critiques lines that were actually touched by a pull request. (Not primarily because of the inline annotations.) I didn't want to burden contributors with errors they didn't introduce themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments