Skip to content

🎨 Palette: Improve "Generate Poster" Button UX #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Improve "Generate Poster" Button UX #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions web_app/static/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,6 @@ <h2>Poster</h2>
</main>
</div>
<div id="toastContainer" class="toast-container"></div>
<div id="loadingOverlay" class="loading-overlay" style="display: none;">
<div class="spinner"></div>
<p>Generating your masterpiece...</p>
</div>
<script src="/static/script.js?v=21"></script>
</body>

Expand Down
20 changes: 13 additions & 7 deletions web_app/static/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const startLineInput = document.getElementById('startLine');
const endLineInput = document.getElementById('endLine');
const themeInput = document.getElementById('themeInput');
const fontInput = document.getElementById('fontInput');
const loadingOverlay = document.getElementById('loadingOverlay');

let currentMetadata = null;
let searchDebounceTimer = null;
Expand Down Expand Up @@ -613,7 +612,8 @@ function handleLyricLineClick(lineNumber) {
async function generatePoster() {
if (!currentMetadata) return;

loadingOverlay.style.display = 'flex';
generateBtn.disabled = true;
generateBtn.textContent = 'Generating...';

const indexingToggle = document.getElementById('indexingToggle');
const accentToggle = document.getElementById('accentToggle');
Expand All @@ -628,23 +628,22 @@ async function generatePoster() {
};

if (payload.type === 'track') {
// Lyrics Logic (Same as before)
const startVal = parseInt(startLineInput.value) || 1;
const endVal = parseInt(endLineInput.value) || 1;
const start = startVal - 1;
const end = endVal;

if (isNaN(start) || isNaN(end) || start >= end) {
loadingOverlay.style.display = 'none';
showToast("Please enter a valid range (Start must be less than End).", "error");
generateBtn.disabled = false;
generateBtn.textContent = 'Generate Poster';
return;
}

payload.lyrics_start = start;
payload.lyrics_end = end;

} else {
// Album Logic
payload.indexing = indexingToggle ? indexingToggle.checked : false;
}

Expand All @@ -669,13 +668,20 @@ async function generatePoster() {
posterContainer.innerHTML = '';
posterContainer.appendChild(img);
showDownloadButton(imageUrl, data.filename);
loadingOverlay.style.display = 'none';
generateBtn.disabled = false;
generateBtn.textContent = 'Generate Poster';
};
img.onerror = () => {
showToast("Error: Failed to load the generated poster image.", "error");
generateBtn.disabled = false;
generateBtn.textContent = 'Generate Poster';
};

} catch (error) {
console.error("Generation failed", error);
showToast(`Error: ${error.message}`, "error");
loadingOverlay.style.display = 'none';
generateBtn.disabled = false;
generateBtn.textContent = 'Generate Poster';
}
}

Expand Down