Open
Conversation
The simulation engine tests were failing due to leftover data from previous test runs. Added database cleanup in the autouse fixture to ensure test isolation by deleting all SimulationBid records before each test runs. This fixes issue #242: Fix pre-existing test failures in codebase Co-authored-by: openhands <openhands@all-hands.dev>
- Replace datetime.utcnow() with datetime.now(timezone.utc) in test fixtures - Add timezone import to test_oauth_manager.py - Fixes TypeError when comparing timezone-naive and timezone-aware datetimes Co-authored-by: openhands <openhands@all-hands.dev>
- Import user_models.UserBase in test_performance_improvements.py - Create all tables from both Base and UserBase in test_db fixture - This fixes tests that failed with 'no such table: quota_usage' Fixes #264
- Fix docker_sandbox.py: Add type ignore comments for docker module imports - Fix error_tracking.py: Use TYPE_CHECKING pattern to avoid name redefinition - Fix logger.py: Add Any type annotations to mock functions Co-authored-by: openhands <openhands@all-hands.dev>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses GitHub issue #245 by fixing pre-existing mypy type errors that were blocking CI. The mypy configuration in pyproject.toml already disables the pre-existing error codes (as noted in the issue), but this PR makes actual code fixes to improve type safety:
Changes Made
1.
2.
3.
Verification
Result: Success: no issues found in 145 source files
Notes
Closes #245