⚡ Bolt: [Template Filtering O(N+M) optimization]#955
Open
Conversation
- Optimizes `frontend/src/components/BehaviorEditor/TemplateSelector/TemplateSelector.tsx` to use a `Set` inside a `useMemo` for template filtering, reducing time complexity from O(N*M) to O(N+M). - Adds an entry to `.jules/bolt.md` reflecting this learning. Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideOptimizes template filtering in TemplateSelector by memoizing an exclusion Set to reduce time complexity, and documents the optimization pattern in the Bolt engineering notes. Class diagram for TemplateSelector filteredTemplates computation using useMemo and SetclassDiagram
class BehaviorTemplate {
+string id
+string name
}
class TemplateSelectorProps {
+string[] excludeTemplateIds
}
class TemplateSelectorState {
+BehaviorTemplate[] templates
}
class TemplateSelector {
+TemplateSelectorProps props
+TemplateSelectorState state
+BehaviorTemplate[] filteredTemplates
+handleTemplateSelect(template)
}
TemplateSelectorProps --> TemplateSelector : provides_props
TemplateSelectorState --> TemplateSelector : provides_state
BehaviorTemplate --> TemplateSelectorState : element_type
BehaviorTemplate --> TemplateSelector : element_type
class FilterComputation {
+BehaviorTemplate[] computeFilteredTemplates(BehaviorTemplate[] templates, string[] excludeTemplateIds)
}
TemplateSelector --> FilterComputation : uses_in_useMemo
class UseMemoHook {
+BehaviorTemplate[] useMemoFilteredTemplates(BehaviorTemplate[] templates, string[] excludeTemplateIds)
}
FilterComputation --> UseMemoHook : wrapped_by
class ExclusionSetStrategy {
+Set~string~ createExcludeSet(string[] excludeTemplateIds)
+boolean isExcluded(Set~string~ excludeSet, string templateId)
}
FilterComputation --> ExclusionSetStrategy : uses
class Set {
+boolean has(string value)
}
ExclusionSetStrategy --> Set : builds_and_queries
Flow diagram for optimized template filtering O(N+M)flowchart TD
A[Start filtering templates] --> B[Input excludeTemplateIds array]
B --> C[Input state.templates array]
C --> D[Create excludeSet from excludeTemplateIds]
D --> E[Iterate over each template in state.templates]
E --> F{excludeSet has template.id?}
F -- Yes --> G[Skip template]
F -- No --> H[Include template in filteredTemplates]
G --> I{More templates?}
H --> I{More templates?}
I -- Yes --> E
I -- No --> J[Return filteredTemplates]
J --> K[End]
%% Complexity annotation
D:::buildSet
E:::iterate
classDef buildSet fill:#e3f2fd,stroke:#1e88e5,stroke-width:1px;
classDef iterate fill:#e8f5e9,stroke:#43a047,stroke-width:1px;
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The
useMemodependency onstate.templatesandexcludeTemplateIdswill only help if these references are stable across renders; if they’re frequently recreated, consider memoizingexcludeSetseparately withuseMemo(() => new Set(excludeTemplateIds), [excludeTemplateIds])and then filtering onstate.templateswith that set to avoid redundantSetconstruction.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `useMemo` dependency on `state.templates` and `excludeTemplateIds` will only help if these references are stable across renders; if they’re frequently recreated, consider memoizing `excludeSet` separately with `useMemo(() => new Set(excludeTemplateIds), [excludeTemplateIds])` and then filtering on `state.templates` with that set to avoid redundant `Set` construction.
## Individual Comments
### Comment 1
<location path="frontend/src/components/BehaviorEditor/TemplateSelector/TemplateSelector.tsx" line_range="87-94" />
<code_context>
- (template) => !excludeTemplateIds.includes(template.id)
- );
+ // ⚡ Bolt optimization: Use Set for O(1) lookups to convert O(N*M) array filtering to O(N+M)
+ const filteredTemplates = useMemo(() => {
+ const excludeSet = new Set(excludeTemplateIds);
+ return state.templates.filter((template) => !excludeSet.has(template.id));
+ }, [state.templates, excludeTemplateIds]);
const handleTemplateSelect = (template: BehaviorTemplate) => {
</code_context>
<issue_to_address>
**suggestion (performance):** Consider memoizing the exclusion Set separately so it only recomputes when `excludeTemplateIds` changes.
Right now the `Set` is rebuilt whenever either `state.templates` or `excludeTemplateIds` changes. Splitting this into two `useMemo` calls lets you rebuild the `Set` only when `excludeTemplateIds` changes, which can help if `templates` updates more frequently:
```ts
const excludeSet = useMemo(() => new Set(excludeTemplateIds), [excludeTemplateIds]);
const filteredTemplates = useMemo(
() => state.templates.filter((template) => !excludeSet.has(template.id)),
[state.templates, excludeSet]
);
```
```suggestion
]);
// Memoize exclusion set so it's only rebuilt when excludeTemplateIds changes
const excludeSet = useMemo(
() => new Set(excludeTemplateIds),
[excludeTemplateIds]
);
// Filter templates on client side for excludeTemplateIds
// ⚡ Bolt optimization: Use Set for O(1) lookups to convert O(N*M) array filtering to O(N+M)
const filteredTemplates = useMemo(
() => state.templates.filter((template) => !excludeSet.has(template.id)),
[state.templates, excludeSet]
);
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
87
to
+94
| ]); | ||
|
|
||
| // Filter templates on client side for excludeTemplateIds | ||
| const filteredTemplates = state.templates.filter( | ||
| (template) => !excludeTemplateIds.includes(template.id) | ||
| ); | ||
| // ⚡ Bolt optimization: Use Set for O(1) lookups to convert O(N*M) array filtering to O(N+M) | ||
| const filteredTemplates = useMemo(() => { | ||
| const excludeSet = new Set(excludeTemplateIds); | ||
| return state.templates.filter((template) => !excludeSet.has(template.id)); | ||
| }, [state.templates, excludeTemplateIds]); |
There was a problem hiding this comment.
suggestion (performance): Consider memoizing the exclusion Set separately so it only recomputes when excludeTemplateIds changes.
Right now the Set is rebuilt whenever either state.templates or excludeTemplateIds changes. Splitting this into two useMemo calls lets you rebuild the Set only when excludeTemplateIds changes, which can help if templates updates more frequently:
const excludeSet = useMemo(() => new Set(excludeTemplateIds), [excludeTemplateIds]);
const filteredTemplates = useMemo(
() => state.templates.filter((template) => !excludeSet.has(template.id)),
[state.templates, excludeSet]
);
Suggested change
| ]); | |
| // Filter templates on client side for excludeTemplateIds | |
| const filteredTemplates = state.templates.filter( | |
| (template) => !excludeTemplateIds.includes(template.id) | |
| ); | |
| // ⚡ Bolt optimization: Use Set for O(1) lookups to convert O(N*M) array filtering to O(N+M) | |
| const filteredTemplates = useMemo(() => { | |
| const excludeSet = new Set(excludeTemplateIds); | |
| return state.templates.filter((template) => !excludeSet.has(template.id)); | |
| }, [state.templates, excludeTemplateIds]); | |
| ]); | |
| // Memoize exclusion set so it's only rebuilt when excludeTemplateIds changes | |
| const excludeSet = useMemo( | |
| () => new Set(excludeTemplateIds), | |
| [excludeTemplateIds] | |
| ); | |
| // Filter templates on client side for excludeTemplateIds | |
| // ⚡ Bolt optimization: Use Set for O(1) lookups to convert O(N*M) array filtering to O(N+M) | |
| const filteredTemplates = useMemo( | |
| () => state.templates.filter((template) => !excludeSet.has(template.id)), | |
| [state.templates, excludeSet] | |
| ); |
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes client-side template exclusion filtering in TemplateSelector by replacing repeated Array.includes lookups with Set.has inside a useMemo, and records the optimization pattern in the Jules Bolt log.
Changes:
- Replaced
excludeTemplateIds.includes(...)inside.filter(...)withSet-based lookups. - Memoized the filtered template list to avoid recomputation when inputs are unchanged.
- Added a Bolt log entry documenting the O(N+M) filtering approach.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/components/BehaviorEditor/TemplateSelector/TemplateSelector.tsx | Uses useMemo + Set to speed up exclusion filtering. |
| .jules/bolt.md | Documents the filtering optimization pattern for future reference. |
Comment on lines
+91
to
+94
| const filteredTemplates = useMemo(() => { | ||
| const excludeSet = new Set(excludeTemplateIds); | ||
| return state.templates.filter((template) => !excludeSet.has(template.id)); | ||
| }, [state.templates, excludeTemplateIds]); |
There was a problem hiding this comment.
useMemo depends on the excludeTemplateIds array identity. When the prop is omitted, the default value [] created during destructuring is a new array every render, so this memo will recompute each render (rebuilding the Set and re-filtering) even when exclusions are effectively unchanged. Consider using a module-level constant for the empty default (so the reference is stable) and/or short-circuiting when excludeTemplateIds.length === 0 to avoid unnecessary work.
- Fix Gitleaks missing GITHUB_TOKEN and deprecated parameters - Remove bandit-exclude-templates which does not exist on PyPI - Fix Dependency Review fail-on-severity invalid parameter - Fix Python 3.14 Dockerfile/Trivy errors by downgrading to Python 3.11-slim - Add psutil and PyJWT missing dependencies to backend requirements - Fix python ruff format missing empty lines in docstrings and uppercase variables Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What
Optimized the array filtering mechanism within$O(N \times M)$ complexity. The new implementation caches the exclusion array into a $O(1)$ constant-time lookups and reducing the overall complexity to $O(N + M)$ .
TemplateSelector.tsx. The previous implementation utilized.includeson an array inside a.filtermethod call, which results inSetwithin auseMemoblock, allowing🎯 Why
When
excludeTemplateIdsandstate.templatesgrow in size, filtering templates linearly creates a significant performance bottleneck resulting in unnecessary lag in the application render cycle. Converting the exclusion array to a Set minimizes allocations and avoids linear lookup traversal, creating a faster more reactive editing experience.📊 Impact
Reduces filtering algorithmic time complexity from$O(N \times M)$ to $O(N + M)$ . For lists above 100-500 elements, filtering speeds are dramatically faster. Furthermore, using
useMemoensures that we skip recalculations across re-renders entirely unless the underlying state changes.🔬 Measurement
Run
pnpm run test:frontendto confirm no regressions are introduced. When tested with hundreds of behavior templates on screen, the UI should render and react immediately without dropped frames.PR created automatically by Jules for task 1380623178334912012 started by @anchapin
Summary by Sourcery
Optimize template selection filtering performance by replacing an O(N*M) array-based exclusion check with a memoized Set-based approach and documenting the pattern in the Bolt guidelines.
Enhancements:
Documentation: