Skip to content

⚡ Bolt: Pre-compile text extraction regex constants#218

Open
anchapin wants to merge 3 commits intomainfrom
bolt-regex-precompilation-opt-1641311279977203139
Open

⚡ Bolt: Pre-compile text extraction regex constants#218
anchapin wants to merge 3 commits intomainfrom
bolt-regex-precompilation-opt-1641311279977203139

Conversation

@anchapin
Copy link
Copy Markdown
Owner

@anchapin anchapin commented Mar 29, 2026

💡 What:
Optimized text parsing methods in cli/utils/keyword_density.py and cli/integrations/job_parser.py by hoisting inline list-based regular expressions into module-level and class-level pre-compiled regex constants (re.compile).

🎯 Why:
Prior to this change, functions like _extract_salary_from_text defined their patterns locally and called re.search() inside for loops. Even with Python's internal caching, this required allocating a list of strings on each invocation and a dictionary lookup. Pre-compiling the expressions completely avoids this overhead, making keyword extractions significantly faster especially when processing large job descriptions or resume dumps.

📊 Impact:
Faster parsing speed and reduced allocation overhead on hot paths for JobParser and KeywordDensityGenerator.

🔬 Measurement:
Run the test suite pytest tests/test_keyword_density.py tests/test_job_parser_integration.py to ensure matching logic correctness, verifying performance via basic profilers.


PR created automatically by Jules for task 1641311279977203139 started by @anchapin

Summary by Sourcery

Enhancements:

  • Introduce module- and class-level pre-compiled regex constants for salary, job type, experience level, job title, and company extraction, replacing ad hoc inline regex usage within parsing methods.

This commit optimizes text extraction operations by hoisting locally defined regex patterns to module/class level compiled constants.
Specifically:
- Defined `_TITLE_PATTERNS` and `_COMPANY_PATTERNS` as module-level constants in `cli/utils/keyword_density.py` and modified `_extract_job_details` to use `pattern.search()`.
- Defined `_SALARY_PATTERNS`, `_JOB_TYPE_PATTERNS`, and `_EXPERIENCE_LEVEL_PATTERNS` as class constants in `cli/integrations/job_parser.py` and updated the extraction methods to utilize `pattern.search()`.

Impact: Faster parsing execution since Python avoids recreating lists and retrieving cached regex patterns from `re.search` repeatedly.

Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Mar 29, 2026

Reviewer's Guide

Pre-compiles frequently used text-extraction regexes into module/class-level constants and updates parsing helpers to reuse these compiled patterns, reducing per-call allocation and regex compilation overhead in JobParser and KeywordDensityGenerator.

Class diagram for precompiled regex usage in JobParser and KeywordDensityGenerator

classDiagram
    class JobParser {
        -_SALARY_PATTERNS: list
        -_JOB_TYPE_PATTERNS: list
        -_EXPERIENCE_LEVEL_PATTERNS: list
        +__init__(cache_dir: OptionalPath)
        -_extract_salary_from_text(text: str) OptionalStr
        -_extract_job_type(html: str) OptionalStr
        -_extract_experience_level(html: str) OptionalStr
    }

    class KeywordDensityGenerator {
        -_TITLE_PATTERNS: list
        -_COMPANY_PATTERNS: list
        -config: Config
        +__init__(config: Config)
        -_extract_job_details(job_description: str) TupleStrStr
    }

    class Config
    class OptionalPath
    class OptionalStr
    class TupleStrStr

    KeywordDensityGenerator --> Config
    JobParser --> OptionalPath
    JobParser --> OptionalStr
    KeywordDensityGenerator --> TupleStrStr
Loading

File-Level Changes

Change Details Files
Hoisted salary, job type, and experience level regexes in JobParser to pre-compiled class-level patterns and updated extraction helpers to use them.
  • Introduced _SALARY_PATTERNS, _JOB_TYPE_PATTERNS, and _EXPERIENCE_LEVEL_PATTERNS as lists of pre-compiled regex objects on JobParser.
  • Refactored _extract_salary_from_text to iterate over self._SALARY_PATTERNS and use pattern.search instead of re.search with inline strings and flags.
  • Refactored _extract_job_type to use self._JOB_TYPE_PATTERNS and pattern.search instead of constructing a local list of pattern strings.
  • Refactored _extract_experience_level to use self._EXPERIENCE_LEVEL_PATTERNS and pattern.search instead of constructing a local list of pattern strings.
cli/integrations/job_parser.py
Hoisted job title and company extraction regexes in keyword_density to pre-compiled module-level patterns and updated _extract_job_details to use them.
  • Added module-level _TITLE_PATTERNS and _COMPANY_PATTERNS lists of pre-compiled regex objects configured with appropriate flags.
  • Updated _extract_job_details to iterate over _TITLE_PATTERNS and _COMPANY_PATTERNS and call pattern.search instead of using local pattern lists with re.search calls.
  • Preserved existing capture groups and post-processing (strip, lower, replace) to maintain behavior while reducing per-call allocations.
cli/utils/keyword_density.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

google-labs-jules bot and others added 2 commits March 29, 2026 23:47
This commit runs `black` on the modified files to ensure they pass CI code quality checks.

Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
Ran `black` using `py310` target-version which satisfies GitHub Actions' `black --check` requirements.

Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant