🛡️ Sentinel: [CRITICAL] Fix PDF Compilation Command Injection and DoS

[anchapin]

🚨 Severity: CRITICAL
💡 Vulnerability: The PDFConverter and CoverLetterGenerator used subprocess.Popen to call pdflatex and pandoc without the -no-shell-escape flag or a timeout. This could allow Remote Code Execution (RCE) via LaTeX injections (e.g., \write18{...}) and Denial of Service (DoS) through infinite compilation loops if pdflatex hangs on invalid inputs.
🎯 Impact: Attackers could execute arbitrary system commands on the host generating the PDFs or cause the server to hang indefinitely, leading to resource exhaustion.
🔧 Fix:

• Enforced -no-shell-escape for pdflatex and --pdf-engine-opt=-no-shell-escape for pandoc.
• Implemented a robust 30-second timeout to the subprocess.communicate() calls.
• Added explicit process cleanup via process.kill() inside subprocess.TimeoutExpired exceptions to prevent zombie processes.
  ✅ Verification: Added/modified tests in tests/test_pdf_security.py to assert that -no-shell-escape is included in the command and subprocess.TimeoutExpired properly handles process kills. Ran python -m pytest which passed 681 tests. Logged Sentinel learning in .jules/sentinel.md.

---

PR created automatically by Jules for task 16983988091594555537 started by @anchapin

Summary by Sourcery

Harden PDF generation against command injection and hangs by securing LaTeX/Pandoc invocations and enforcing timeouts.

Bug Fixes:

• Prevent potential command injection in PDF generation by disabling shell escapes for pdflatex and pandoc engines.
• Avoid denial-of-service scenarios during PDF compilation by adding timeouts and explicit process cleanup for hanging subprocesses.

Documentation:

• Document the new Sentinel learning about securing PDF compilation commands and enforcing timeouts in .jules/sentinel.md.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's Guide

Hardened PDF generation by adding no-shell-escape flags and timeouts around pdflatex/pandoc invocations, including explicit process cleanup on timeout and a Sentinel entry documenting the vulnerability and mitigation.

Sequence diagram for hardened PDF compilation with timeout and no_shell_escape

sequenceDiagram
    actor User
    participant Caller as PDFRequestHandler
    participant Converter as PDFConverter
    participant Subproc as subprocess_Popen
    participant Engine as pdflatex

    User ->> Caller: request_pdf(tex_content)
    Caller ->> Converter: _compile_pdflatex(tex_path, output_path, working_dir)

    Converter ->> Subproc: Popen([pdflatex, -interaction=nonstopmode, -no-shell-escape, tex_path.name])
    Subproc ->> Engine: start_compilation(tex_file)

    alt compilation_finishes_within_30s
        Converter ->> Subproc: communicate(timeout=30)
        Subproc -->> Converter: stdout, stderr
        Converter ->> Converter: check returncode or output_path.exists()
        Converter -->> Caller: True
        Caller -->> User: return_generated_pdf
    else compilation_hangs_or_infinite_loop
        Converter ->> Subproc: communicate(timeout=30)
        Subproc --x Converter: raise TimeoutExpired
        Converter ->> Subproc: kill()
        Converter ->> Subproc: communicate()
        Subproc -->> Converter: stdout, stderr
        Converter ->> Caller: raise RuntimeError(PDF compilation timed out)
        Caller -->> User: error_response
    end

Loading

File-Level Changes

Change	Details	Files
Harden pdflatex invocation in cover letter PDF compilation against command injection and hangs.	Add -no-shell-escape flag to the pdflatex command used for cover letter generation. Wrap process.communicate() with a 30-second timeout to avoid hanging compilations. On timeout, kill the pdflatex process, drain stdout/stderr, and raise a RuntimeError to signal failure. Preserve existing success conditions based on return code or output file existence.	cli/generators/cover_letter_generator.py
Harden pandoc-based PDF fallback in cover letter generation with restricted engine options and timeouts.	Extend pandoc invocation to include --pdf-engine-opt=-no-shell-escape to disable shell escapes in the LaTeX engine. Add a 30-second timeout around communicate() for pandoc, mirroring pdflatex handling. Ensure the pandoc process is killed and a RuntimeError is raised if the timeout is exceeded while still reading outputs. Keep existing success checks using process return code and output path existence.	cli/generators/cover_letter_generator.py
Secure the main PDFConverter pdflatex compilation step with no-shell-escape and timeout handling.	Insert -no-shell-escape into the pdflatex command in the core PDF converter. Protect communicate() with a 30-second timeout to mitigate DoS via hanging compilations. On TimeoutExpired, terminate the process, collect outputs, and raise a RuntimeError to propagate the failure state. Retain existing logic that treats either a zero exit code or presence of the output file as success.	cli/pdf/converter.py
Secure the PDFConverter pandoc fallback path similarly with shell-escape restrictions and timeouts.	Augment pandoc invocation with --pdf-engine-opt=-no-shell-escape for its xelatex engine. Add a 30-second timeout around communicate() and kill the process on timeout. Raise a RuntimeError after cleanup so callers can handle timeouts explicitly while keeping output- or return-code-based success criteria unchanged.	cli/pdf/converter.py
Document the newly discovered PDF compilation command injection and DoS vulnerability and its mitigations in Sentinel docs.	Append a new Sentinel learning entry describing the lack of -no-shell-escape and timeouts for pdflatex/pandoc. Record the security implications (RCE and DoS) and the lessons learned about external tool invocation and timeout handling. Capture prevention guidelines, including always disabling shell escapes and enforcing timeouts with explicit process cleanup.	.jules/sentinel.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The timeout/kill/communicate pattern is duplicated in four places; consider extracting a small helper (e.g., run_with_timeout(cmd, cwd=None, timeout=30)) to centralize the behavior and reduce the chance of divergence in future changes.
• The hard-coded 30-second timeout is currently embedded directly in the subprocess calls; it may be cleaner to define this as a module-level constant or configuration parameter so it can be tuned without code changes.
• Raising a generic RuntimeError("PDF compilation timed out") drops potentially useful diagnostics from stderr; consider including relevant parts of stderr in the exception message or logging it before raising to aid debugging operational issues.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The timeout/kill/communicate pattern is duplicated in four places; consider extracting a small helper (e.g., `run_with_timeout(cmd, cwd=None, timeout=30)`) to centralize the behavior and reduce the chance of divergence in future changes.
- The hard-coded 30-second timeout is currently embedded directly in the subprocess calls; it may be cleaner to define this as a module-level constant or configuration parameter so it can be tuned without code changes.
- Raising a generic `RuntimeError("PDF compilation timed out")` drops potentially useful diagnostics from `stderr`; consider including relevant parts of `stderr` in the exception message or logging it before raising to aid debugging operational issues.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}