feat: add --persist so SNO VM survives the host reboot#7
Open
xiormeesh wants to merge 2 commits intoandfasano:mainfrom
Open
feat: add --persist so SNO VM survives the host reboot#7xiormeesh wants to merge 2 commits intoandfasano:mainfrom
xiormeesh wants to merge 2 commits intoandfasano:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using miniagent/SNO instead of Openshift Local/crc sometimes the host needs to be rebooted without losing the SNO VM, this PR
--persistflag defaulting to falseI've decided to gate the functionality behind
--persistflag because based on our previous conversations most users need miniagent for quick tests and I wanted to keep the ephemeral usecase as is.