Conversation
that intended to work on the pr and commit document respectively into common methods. The type of the document is deduced from the document descriptor alist. Fixed read-only buffer case that can turn in due to automatic diff-mode on .diff extension. Extended `github-review-save-diff` with `github-review-save-commit-id-in-buffer` branch to controls whether to add the commit and its parent id info to the buffer as persistent buffer-locals.
|
This is a test top-level comment. |
| (pr-object (-> x (elt 1))) | ||
| (comms (github-review-a-get pr-object 'comments)) | ||
| (commit-id (github-review-a-get (github-review-a-get pr-object 'head) 'sha)) | ||
| (parent-id (github-review-a-get (github-review-a-get pr-object 'base) 'sha)) |
There was a problem hiding this comment.
BASE and HEAD refs are found differently with graphql.
There was a problem hiding this comment.
Self-Reply 1 by emoonrain starts a review.
There was a problem hiding this comment.
My first reply to a plain code-block comment.
There was a problem hiding this comment.
BASE and HEAD refs are found differently with graphql.
Replied in a while, to expect
- ReplyTo == 950695965;
2. This comment to be appended to 950697543.
There was a problem hiding this comment.
Self-Reply 1 by emoonrain starts a review.
A reply but expectedly a part of Another 2nd top-level review.
emoonrain
left a comment
emoonrain
left a comment
There was a problem hiding this comment.
The 1st two comment Review is completed.
| (pr-object (-> x (elt 1))) | ||
| (comms (github-review-a-get pr-object 'comments)) | ||
| (commit-id (github-review-a-get (github-review-a-get pr-object 'head) 'sha)) | ||
| (parent-id (github-review-a-get (github-review-a-get pr-object 'base) 'sha)) |
There was a problem hiding this comment.
Self-Reply 1 by emoonrain starts a review.
| (github-review-a-assoc 'top-level-comments issues-comments) | ||
| (github-review-a-assoc 'reviews reviews))))))) | ||
| (github-review-a-assoc 'reviews reviews))) | ||
| (list commit-id parent-id))))) |
There was a problem hiding this comment.
A 2nd comment into the opened review.
There was a problem hiding this comment.
1 followup to the 1st review as plain comment.
| (parent-id (github-review-a-get (github-review-a-get pr-object 'base) 'sha)) | ||
| (review_comments (github-review-a-get pr-object 'review_comments)) | ||
| (issues-comments (when (and (> comms 0) github-review-fetch-top-level-and-review-comments) (-> x (elt 2)))) | ||
| (reviews (when (and (> review_comments 0) github-review-fetch-top-level-and-review-comments) github-review-fetch-top-level-and-review-comments (-> x (elt 3))))) |
There was a problem hiding this comment.
Reply to a reply in a 2nd review being started.
| (parent-id (github-review-a-get (github-review-a-get pr-object 'base) 'sha)) | ||
| (review_comments (github-review-a-get pr-object 'review_comments)) | ||
| (issues-comments (when (and (> comms 0) github-review-fetch-top-level-and-review-comments) (-> x (elt 2)))) | ||
| (reviews (when (and (> review_comments 0) github-review-fetch-top-level-and-review-comments) github-review-fetch-top-level-and-review-comments (-> x (elt 3))))) |
There was a problem hiding this comment.
Reply to a reply in a 2nd review being started.
andrelkin
left a comment
andrelkin
left a comment
There was a problem hiding this comment.
Some top-level review.
andrelkin
left a comment
andrelkin
left a comment
There was a problem hiding this comment.
The end of the Another 2nd top-level.
| (defun github-review-format-commit-url (kind commit-alist) | ||
| "Format a url for accessing the commit. | ||
| (defun github-review-format-url (kind id-alist) | ||
| "Format a url for accessing either a pr or commit. |
There was a problem hiding this comment.
A new 1st comment of the Another (2nd) some top-level-review.
| (pr-object (-> x (elt 1))) | ||
| (comms (github-review-a-get pr-object 'comments)) | ||
| (commit-id (github-review-a-get (github-review-a-get pr-object 'head) 'sha)) | ||
| (parent-id (github-review-a-get (github-review-a-get pr-object 'base) 'sha)) |
There was a problem hiding this comment.
Self-Reply 1 by emoonrain starts a review.
A reply but expectedly a part of Another 2nd top-level review.
2 participants
Same entry point as for PR.