Conversation
todo: create review-comment revs on the review branch.
| (let ((query (format "query { | ||
| repository(name: \"%s\", owner: \"%s\") { | ||
| pullRequest(number: %s){ | ||
| reviewThreads(first: 100) { edges { node {comments(first: 10) { |
There was a problem hiding this comment.
1.1 reviewThreads view should be sufficient.
There was a problem hiding this comment.
2.1 reply to the review's 1.1.
There was a problem hiding this comment.
A 5th(?) 5.0 multi-comment hopefully multi-commit review starts to reply 2.1.
| comments(first: 50) | ||
| { nodes { bodyText originalPosition position outdated path databaseId} }} | ||
| { nodes { bodyText originalPosition position outdated path databaseId originalCommit { abbreviatedOid } replyTo { author { login } databaseId } resourcePath} }} | ||
| } } |
There was a problem hiding this comment.
1.2. It's unclear how to make use of ReplyTo.
| (let ((query (format "query { | ||
| repository(name: \"%s\", owner: \"%s\") { | ||
| pullRequest(number: %s){ | ||
| reviewThreads(first: 100) { edges { node {comments(first: 10) { |
There was a problem hiding this comment.
A reply to 2.0 as solitary comment over the 1-2 commit range patch. Expected originalCommitId = HEAD.
There was a problem hiding this comment.
A solitary comment review reply via HEAD~1 commit to prove it'd be original-commit-id.
| (let ((query (format "query { | ||
| repository(name: \"%s\", owner: \"%s\") { | ||
| pullRequest(number: %s){ | ||
| reviewThreads(first: 100) { edges { node {comments(first: 10) { |
There was a problem hiding this comment.
2.1 reply to the review's 1.1.
github-review.el
Outdated
| nodes { author { login } bodyText state | ||
| comments(first: 50) | ||
| { nodes { bodyText originalPosition position outdated path databaseId} }} | ||
| { nodes { bodyText originalPosition position outdated path databaseId originalCommit { abbreviatedOid } replyTo { author { login } databaseId } resourcePath} }} |
| (a-assoc pr-alist 'sha .data.repository.pullRequest.headRef.target.oid) | ||
| (github-review-format-diff (-first-item x) .data.repository.pullRequest) | ||
| (a-assoc pr-alist 'sha .data.repository.pullRequest.baseRef.target.oid))))) | ||
| (a-assoc pr-alist 'sha .data.repository.pullRequest))))) |
There was a problem hiding this comment.
A solitary commit review aka 3.0. Commit bc.. should reflect that in api call results.
There was a problem hiding this comment.
5.1 on bc.. (to expect original-commit-id as that).
andrelkin
left a comment
andrelkin
left a comment
There was a problem hiding this comment.
5.1,2 heterogeneous commit review is completed.
| (let ((query (format "query { | ||
| repository(name: \"%s\", owner: \"%s\") { | ||
| pullRequest(number: %s){ | ||
| reviewThreads(first: 100) { edges { node {comments(first: 10) { |
There was a problem hiding this comment.
A 5th(?) 5.0 multi-comment hopefully multi-commit review starts to reply 2.1.
| (a-assoc pr-alist 'sha .data.repository.pullRequest.headRef.target.oid) | ||
| (github-review-format-diff (-first-item x) .data.repository.pullRequest) | ||
| (a-assoc pr-alist 'sha .data.repository.pullRequest.baseRef.target.oid))))) | ||
| (a-assoc pr-alist 'sha .data.repository.pullRequest))))) |
There was a problem hiding this comment.
5.1 on bc.. (to expect original-commit-id as that).
2 participants
Just to test github API. As a secondary note, needed
dummy1as the base 'cosmasterled to a wrong commit set difference.