Open
Conversation
Before this change the dockerfile was using the tarball for a tag ref 0.4.2, last release was 2022. This change moves to the dev branch tarball which supposedly works.
When building the image there was a warning on case differences This modifies soo all references are upper case. Shell script for building and pushing to docker hub was also using the tmigone docker repo so required modification to run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change the dockerfile was using the tarball for a tag ref
0.4.2which was last released in 2022.This change moves to the
devbranch tarball which supposedly works.I am unsure how to validate the local image I built other than it building successfully. Let me know if there is other validation required.
docker build -f Dockerfile.pulseaudio.template --build-arg BALENA_ARCH=amd64 .Noticed the /plugins/spotify/Dockerfile.template is actually using the docker hub version which I presume is run manually as the github workflow publishes to ghcr.