feat: attr_get / attrs_get attribute accessors (1.4.0)#6
Merged
Conversation
Add module-level sdp.attr_get(block, name) and sdp.attrs_get(block, name) to look up decomposed attributes by name on a session or media block, mirroring grammar.base.params_get for the outer attributes array. attr_get returns the first match (or nil); attrs_get returns all matches in order. Removes the hand-rolled scan from every consumer. Bumps rockspec to 1.4.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two module-level accessors that look up decomposed attributes by name on a block (a `doc.session` or any `doc.media[i]`):
Both are nil-safe and mirror `parse_sdp.grammar.base.params_get` (the inner-`fmtp` accessor) for the outer `attributes` array, so consumers no longer hand-roll the scan over the ordered array. `attrs_get` earns its place because same-name attributes are common (`rtpmap` / `fmtp` / `ssrc` / `rtcp-fb`).
Requested by the `lnmos` projection layer, which was the only consumer still hand-rolling `find_attr`.
Design
Tests
+9 cases in `spec/library_spec.lua` (first / all / session-level / flag-only / miss / nil-safe / hand-built). Full hermetic suite green.
Release
Bumps rockspec to 1.4.0 (additive, backward-compatible). dkjson dependency unchanged.
🤖 Generated with Claude Code