This repository was archived by the owner on Dec 10, 2024. It is now read-only.
Fix issue 1 - Branch Master is not the starting point#13
Open
lucasferreiramachado wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Issue 1: Branch Master is not the starting point
related by @evowizz . Thanks!
Problem to solve:
According to page #2 of the codelab, we are supposed to add Hilt to the project ourselves. However, as seen in the following lines, Hilt is already included in this project in Master.
android-dagger-to-hilt/build.gradle Line 5 in 267db26
android-dagger-to-hilt/build.gradle Line 13 in 267db26
android-dagger-to-hilt/app/build.gradle Line 9 in 267db26
android-dagger-to-hilt/app/build.gradle Lines 71 to 73 in 267db26
Moreover, this also prevent us from running the project at its starting point, because Hilt produces the following issue:
com\example\android\dagger\di\AppSubcomponents.java:7: error: [Hilt] public final class AppSubcomponents { ^ com.example.android.dagger.di.AppSubcomponents must also be annotated with @InstallIn. [Hilt] Processing did not complete. See error above for detailsSolution proposal: