-
Notifications
You must be signed in to change notification settings - Fork 328
Modify Vertex AI generateContent() snippet #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @kkuan2011, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly refactors the generateContent() snippet to be a suspend function and removes the explicit CoroutineScope, which is a great improvement for idiomatic Kotlin coroutine usage. My review includes one suggestion to further enhance code clarity by leveraging the class structure.
| fun generateText(scope: CoroutineScope) { | ||
| // [START android_snippets_vertex_ai_generate_content] | ||
| // [START android_snippets_vertex_ai_generate_content] | ||
| suspend fun generateText(model: GenerativeModel) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since generateText is a method within the VertexAiGeminiApi class which has a model property, it's more idiomatic for this method to use the instance's model property rather than accepting one as a parameter. This avoids shadowing the class property and makes the code clearer.
By removing the parameter, the method will implicitly use the model property from the class instance.
| suspend fun generateText(model: GenerativeModel) { | |
| suspend fun generateText() { |
Per code review feedback (#686), change the function to be a suspend function and remove the coroutine scope.