Open
Conversation
Introduce a new lib-datasource-ktor module similar to `libraries/datasource_okhttp`. Providing KtorDataSource as an alternative HTTP data source implementation using Ktor client.
icbaker
reviewed
Feb 24, 2026
In the past we have found Robolectric is not realistic enough for testing fiddly edge cases in HTTP stacks, so running on an emulator with real Android OS is better.
icbaker
requested changes
Feb 24, 2026
Collaborator
icbaker
left a comment
icbaker
left a comment
There was a problem hiding this comment.
I've pushed a few commits, and added a few comments too
libraries/datasource_ktor/src/main/java/androidx/media3/datasource/ktor/KtorDataSource.kt
Outdated
Show resolved
Hide resolved
libraries/datasource_ktor/src/main/java/androidx/media3/datasource/ktor/KtorDataSource.kt
Outdated
Show resolved
Hide resolved
libraries/datasource_ktor/src/main/java/androidx/media3/datasource/ktor/KtorDataSource.kt
Outdated
Show resolved
Hide resolved
We can promote it to stable later
io.ktor.http.Headers it self is a case-insensitive map already
k88936
force-pushed
the
feat/ktor-datasource
branch
from
44e93e3 to
b51daad
Compare
This reverts commit b51daad. fix: failed test case , we not only need a case-insensitively stored map, we also need a case-insensitively look up map.
k88936
force-pushed
the
feat/ktor-datasource
branch
from
77621e9 to
8653e59
Compare
k88936
force-pushed
the
feat/ktor-datasource
branch
from
c0f7038 to
919b31d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a new lib-datasource-ktor module similar to
libraries/datasource_okhttp, providing KtorDataSource as an alternative HTTP data source implementation using Ktor client to solve issue #1646 .What changed
Why
I recent met the same problem for maintaining both a okhttp client and a ktor client, similar to #1646 (comment)