feat: Add logging#45
Open
maxgolish wants to merge 1 commit into
Open
Conversation
Owner
|
#36 посмотри, какие здесь зависимости, нам нужны такие же. Еще там норм формат логирования указан четко. |
andrsuh
reviewed
Feb 10, 2021
| writer.write(command); | ||
| RespArray arrayResponse = (RespArray) reader.readObject(); | ||
| System.out.println("Client got response to command id: " + arrayResponse.getObjects().get(0).asString()); | ||
| log.debug("Client got response to command id: " + arrayResponse.getObjects().get(0).asString()); |
Owner
There was a problem hiding this comment.
log.debug("Client got response to command id: {}", arrayResponse.getObjects().get(0).asString())
Owner
There was a problem hiding this comment.
и везде так нужно сделать, это более эффективно
andrsuh
reviewed
Feb 10, 2021
| return executeNextCommand(command); | ||
| } catch (Exception e) { | ||
| System.out.println(e.getMessage()); | ||
| log.error(e.getMessage()); |
Owner
There was a problem hiding this comment.
e.getMessage() = так исключения не логируются. лучше сделать сообщение и передать исключение внутрь.
log.error("Command execution failed: ", e)
andrsuh
reviewed
Feb 10, 2021
| serverProperties.load(this.getClass().getClassLoader().getResourceAsStream("server.properties")); | ||
| } catch (IOException ex) { | ||
| System.out.println("Error: server.properties file not found, using default values"); | ||
| log.warn("Error: server.properties file not found, using default values"); |
andrsuh
reviewed
Feb 10, 2021
| clientIOWorkers.submit(new ClientTask(clientSocket, databaseServer)); | ||
| } catch (Throwable t) { | ||
| System.out.println("Server acceptor thread exception: " + t); | ||
| log.error("Server acceptor thread exception: " + t); |
Owner
There was a problem hiding this comment.
log.error("Server acceptor thread exception: ", t);
andrsuh
reviewed
Feb 10, 2021
| return databaseServer.executeNextCommand(msg).get(); | ||
| } catch (Exception e) { | ||
| System.out.println(e.getMessage()); | ||
| log.error(e.getMessage()); |
andrsuh
reviewed
Feb 10, 2021
| } | ||
| } catch (IOException e) { | ||
| System.out.println("Client socket threw IO Exception " + e.getMessage()); | ||
| log.error("Client socket threw IO Exception {}" ,e.getMessage()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.