Add Python3 pre-commit config checks with pylint and mypy#7
Closed
bernhardkaindl wants to merge 1 commit intoandyhhp:masterfrom
Closed
Add Python3 pre-commit config checks with pylint and mypy#7bernhardkaindl wants to merge 1 commit intoandyhhp:masterfrom
bernhardkaindl wants to merge 1 commit intoandyhhp:masterfrom
Conversation
c94bdea to
afeba10
Compare
Also enables spell checking when pre-commit runs pylint. - Add pyproject.toml with config for mypy, black and isort - Add .pre-commit-config.yaml for https://github.com/pre-commit - Add GitHub action with cache to .github/workflows/build.yml - Fix execute permissions on files found by pre-commit checks. - build/mkinfo.py: Add module docstring as requested by pylint. - tests/python/conftest.py: Add a pytest fixture for unit-tests - tests/python/test_parse_test_instance_string.py: Add an initial unit test for xtf-runner using the pytest fixture. - xtf-runner: - Import json always as Python2.7 is the minium version - Add comments to locally disable checks where needed. - Resolve a line-too-long while resolving a no-else-return Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
afeba10 to
1b1d562
Compare
Contributor
Author
|
Superseded by the devel branch and #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates:
pre-commitrunspylint(uses pyenchant)tests/python/conftest.py: Add a pytest fixture for unit-teststests/python/test_parse_test_instance_string.py: Add an initial unit test for xtf-runner using the pytest fixture.Updated commit message:
This PR is ment as an example, but it may also be taken as-is or used as starting point for more:
Add Python3 pre-commit config checks with pylint and mypy:
.pre-commit-config.yamlfor https://github.com/pre-commit with a quick checks and automatic fixups:.github/workflows/build.yml.pylintrcto also support passing the latest Python3 pylint checks while toleratingpylintconfig settings for old Python2-only pylint versions.build/mkinfo.py.xtf-runner:type: ignore[no-redef]to for Python3 mypy and add a Python2-compatible type comment formypy.pylint: disablecomments to locations where appropriateline-too-longwarning while resolving ano-else-returnpylint warning.