fix(core): ffmpeg version specific transient test failures#58
Draft
andykais-claude wants to merge 2 commits into
Draft
fix(core): ffmpeg version specific transient test failures#58andykais-claude wants to merge 2 commits into
andykais-claude wants to merge 2 commits into
Conversation
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
andykais
reviewed
Mar 14, 2026
Comment on lines
+1039
to
+1047
| const andrew_duration = groups_sorted_by_duration_desc.results[0].group.duration | ||
| const alice_duration = groups_sorted_by_duration_desc.results[1].group.duration | ||
| const bob_duration = groups_sorted_by_duration_desc.results[2].group.duration | ||
| ctx.assert.not_equals(andrew_duration, undefined) | ||
| ctx.assert.not_equals(alice_duration, undefined) | ||
| ctx.assert.not_equals(bob_duration, undefined) | ||
| ctx.assert.almost_equals(andrew_duration!, 16.733333, 0.01) | ||
| ctx.assert.almost_equals(alice_duration!, 6.92, 0.1) | ||
| ctx.assert.almost_equals(bob_duration!, 0, 0.001) |
Owner
There was a problem hiding this comment.
this can all be collapsed into
Suggested change
| const andrew_duration = groups_sorted_by_duration_desc.results[0].group.duration | |
| const alice_duration = groups_sorted_by_duration_desc.results[1].group.duration | |
| const bob_duration = groups_sorted_by_duration_desc.results[2].group.duration | |
| ctx.assert.not_equals(andrew_duration, undefined) | |
| ctx.assert.not_equals(alice_duration, undefined) | |
| ctx.assert.not_equals(bob_duration, undefined) | |
| ctx.assert.almost_equals(andrew_duration!, 16.733333, 0.01) | |
| ctx.assert.almost_equals(alice_duration!, 6.92, 0.1) | |
| ctx.assert.almost_equals(bob_duration!, 0, 0.001) | |
| ctx.assert.almost_equals(groups_sorted_by_duration_desc.results[0].group.duration!, 16.733333, 0.01) | |
| ctx.assert.almost_equals(groups_sorted_by_duration_desc.results[1].group.duration!, 6.92, 0.1) | |
| ctx.assert.almost_equals(groups_sorted_by_duration_desc.results[2].group.duration!, 0, 0.001) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
almost_equalsassertion and updatemedia.test.tsto resolve transient FFmpeg-related float precision test failures.