Skip to content

fix(core): ffmpeg version specific transient test failures#58

Draft
andykais-claude wants to merge 2 commits into
mainfrom
cursor/core-ffmpeg-test-failures-f250
Draft

fix(core): ffmpeg version specific transient test failures#58
andykais-claude wants to merge 2 commits into
mainfrom
cursor/core-ffmpeg-test-failures-f250

Conversation

@andykais-claude

Copy link
Copy Markdown
Collaborator

Add almost_equals assertion and update media.test.ts to resolve transient FFmpeg-related float precision test failures.


Open in Web Open in Cursor 

Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
@cursor

cursor Bot commented Mar 9, 2026

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@andykais andykais changed the title Core ffmpeg test failures fix(core): ffmpeg version specific transient test failures Mar 9, 2026
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
Comment on lines +1039 to +1047
const andrew_duration = groups_sorted_by_duration_desc.results[0].group.duration
const alice_duration = groups_sorted_by_duration_desc.results[1].group.duration
const bob_duration = groups_sorted_by_duration_desc.results[2].group.duration
ctx.assert.not_equals(andrew_duration, undefined)
ctx.assert.not_equals(alice_duration, undefined)
ctx.assert.not_equals(bob_duration, undefined)
ctx.assert.almost_equals(andrew_duration!, 16.733333, 0.01)
ctx.assert.almost_equals(alice_duration!, 6.92, 0.1)
ctx.assert.almost_equals(bob_duration!, 0, 0.001)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can all be collapsed into

Suggested change
const andrew_duration = groups_sorted_by_duration_desc.results[0].group.duration
const alice_duration = groups_sorted_by_duration_desc.results[1].group.duration
const bob_duration = groups_sorted_by_duration_desc.results[2].group.duration
ctx.assert.not_equals(andrew_duration, undefined)
ctx.assert.not_equals(alice_duration, undefined)
ctx.assert.not_equals(bob_duration, undefined)
ctx.assert.almost_equals(andrew_duration!, 16.733333, 0.01)
ctx.assert.almost_equals(alice_duration!, 6.92, 0.1)
ctx.assert.almost_equals(bob_duration!, 0, 0.001)
ctx.assert.almost_equals(groups_sorted_by_duration_desc.results[0].group.duration!, 16.733333, 0.01)
ctx.assert.almost_equals(groups_sorted_by_duration_desc.results[1].group.duration!, 6.92, 0.1)
ctx.assert.almost_equals(groups_sorted_by_duration_desc.results[2].group.duration!, 0, 0.001)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants