impl(web): ToggleFullScreen and ToggleFitMedia keybinds#60
Merged
Conversation
cursor
Bot
force-pushed
the
cursor/media-fullscreen-mode-5641
branch
from
d7043f9 to
a2ef89b
Compare
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
- Dialog elements cannot use requestFullscreen() per HTML spec - Changed to fullscreen the inner div container instead - Fixes scoping issue where controller was used before being defined Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/media-fullscreen-mode-5641
branch
from
c73a1d3 to
d3dde0d
Compare
cursor
Bot
changed the title
andykais
reviewed
Jul 7, 2026
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
andykais
approved these changes
Jul 8, 2026
andykais
changed the title
Co-authored-by: andykais-claude <andykais-claude@users.noreply.github.com>
andykais
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToggleFullScreenToggleFitMediato switch between original vs 'fit' media sizingCustomEventthey actually receive soe.detail.data.keyboard_eventis type-safe (fixes thesvelte-checkerrors inMediaView.svelteandTagAutoCompleteInput.svelte)Vision Testing
forager gui):Media: original⇄Media: fill, visibly resizing the mediaCtrl+Spacetoggles the same fit mode while the viewer is openfenters fullscreen; firstEscapeexits fullscreen (viewer stays open), secondEscapecloses the viewerdeno eval+ Playwright against system Chrome):finsertsfand does not callrequestFullscreen(input_value="f",rf_calls_input_focus=0)fstill calls fullscreen (rf_calls_after_dialog_f=1)