chore(deps): bump esp-hal-ota from 0.5.0 to 0.5.1#586
Merged
Conversation
|
PR author is in the excluded authors list. |
andymai
added a commit
that referenced
this pull request
Jun 13, 2026
## Summary Rust 1.96.0's clippy promoted `clippy::suboptimal_flops` to fire on the single-pole IIR smoothing step in `mouth_from_audio.rs`, which broke the **Host (core + sim + drivers)** CI gate on `main`. Because that gate is red on `main`, every open PR inherits the failure — all four open dependabot PRs (#586, #585, #584, #551) are blocked solely by this. Clippy suggests `f32::mul_add`, but that lowers to `libm::fmaf` on the no_std Xtensa target — exactly the dependency this module is engineered to avoid (it sits beside the libm-free `one_minus_exp_approx` approximation). This matches the standing decision already documented in `head_from_attention` and `lost_target_search`, so the fix `#[allow]`s the lint with the same rationale rather than taking clippy's suggestion. ## Test plan - `just check` — fmt + workspace clippy (`-D warnings`) + host tests all green locally - `cargo clippy -p stackchan-core --all-targets --all-features -- -D warnings` passes
Owner
|
@dependabot rebase |
Bumps [esp-hal-ota](https://github.com/filipton/esp-hal-ota) from 0.5.0 to 0.5.1. - [Commits](https://github.com/filipton/esp-hal-ota/commits) --- updated-dependencies: - dependency-name: esp-hal-ota dependency-version: 0.5.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
4aa1422 to
59cb4b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps esp-hal-ota from 0.5.0 to 0.5.1.
Commits