Skip to content

fix(core): allow suboptimal_flops on mouth-audio smoothing lerp #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andymai merged 1 commit into from
Jun 13, 2026
Merged

fix(core): allow suboptimal_flops on mouth-audio smoothing lerp #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/stackchan-core/src/modifiers/mouth_from_audio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,12 @@ impl Modifier for MouthFromAudio {
)]
let dt_ms_f32 = dt_ms as f32;
let alpha = one_minus_exp_approx(dt_ms_f32 / tau_ms);
self.current += (target - self.current) * alpha;
#[allow(
clippy::suboptimal_flops,
reason = "no_std Xtensa lacks f32::mul_add; libm::fmaf is heavier than the savings"
)]
let next = self.current + (target - self.current) * alpha;
self.current = next;
entity.face.mouth.mouth_open = clamp_unit(self.current);
}
}
Expand Down