Skip to content

Update default JSONPointer backend #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angela-tarantula merged 2 commits into from
Apr 1, 2026
Merged

Update default JSONPointer backend #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b05afad
fix earlier docs
angela-tarantula Apr 1, 2026
033807f
my upstream bugfix was merged, so _DEFAULT_POINTER_CLS can be simpler…
angela-tarantula Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ writes:

- [`scorecard.yml`](scorecard.yml)
- [`dependabot-update-openapi-snapshots.yml`](dependabot-update-openapi-snapshots.yml)
(mints app token before regenerating and committing snapshots)

This keeps write operations explicit and reduces default token blast radius.

Expand Down
16 changes: 1 addition & 15 deletions jsonpatchx/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@ def parts(self) -> Sequence[str]:


class _DEFAULT_POINTER_CLS(JsonPointer): # type: ignore[misc]
# fixes https://github.com/stefankoegl/python-json-pointer/issues/63
# and https://github.com/stefankoegl/python-json-pointer/issues/70
# fixes https://github.com/stefankoegl/python-json-pointer/issues/70
@override
@classmethod
def get_part(cls, doc, part): # type: ignore[no-untyped-def]
Expand All @@ -100,21 +99,8 @@ def get_part(cls, doc, part): # type: ignore[no-untyped-def]
f"Cannot apply token {part!r} to non-container type {type(doc)}"
)
key = super().get_part(doc, part)
if isinstance(key, int) and not _NONNEGATIVE_ARRAY_INDEX_PATTERN.fullmatch(
str(part)
):
raise JPException("'%s' is not a valid sequence index" % part)
return key

@override
def to_last(self, doc): # type: ignore[no-untyped-def] # pragma: no cover
doc, key = super().to_last(doc)
if isinstance(key, int) and not _NONNEGATIVE_ARRAY_INDEX_PATTERN.fullmatch(
str(self.parts[-1])
):
raise JPException("'%s' is not a valid sequence index" % self.parts[-1])
return doc, key

@override
def walk(self, doc, part): # type: ignore[no-untyped-def]
part = self.get_part(doc, part) # type: ignore[no-untyped-call]
Expand Down
Loading