This repository was archived by the owner on May 25, 2019. It is now read-only.
Re-use already created jqplot object when re-plotting, and added a destroy process.#16
Open
yoichiro wants to merge 1 commit intoangular-ui:masterfrom
Open
Re-use already created jqplot object when re-plotting, and added a destroy process.#16yoichiro wants to merge 1 commit intoangular-ui:masterfrom
yoichiro wants to merge 1 commit intoangular-ui:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original implementation does the removing all child elements when re-plotting. I guess that the way is heavy. Instead its way, we can use jqplot.replot() function for re-plotting.
Also, the original implementation does not call "destroy()" function of the jqplot object. If the element was removed, then the jqplot should be destroyed before the element is deleted.
Would be great if you merge my pull request. Thank you for your reviewing.