refactor: move baseUrl fallback logic to paths-plugin.ts#32677
refactor: move baseUrl fallback logic to paths-plugin.ts#32677alan-agius4 merged 3 commits intoangular:mainfrom
baseUrl fallback logic to paths-plugin.ts#32677Conversation
This ensure that we do not set `baseUrl` internally which would trigger a deprecation warning.
There was a problem hiding this comment.
Code Review
This pull request refactors the fallback logic for baseUrl by moving it from AngularWebpackPlugin to TypeScriptPathsPlugin. This is a good change as it centralizes the path-related logic and avoids modifying the compilerOptions object directly, which helps prevent a deprecation warning. My review includes a minor suggestion to improve the type assertion in paths-plugin.ts for better type safety and code clarity.
e8431e6 to
395840c
Compare
395840c to
a377f34
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This ensure that we do not set
baseUrlinternally which would trigger a deprecation warning.