Skip to content

Pr takeover 33240#33263

Merged
tjshiu merged 4 commits into
angular:mainfrom
tjshiu:pr-takeover-33240
May 19, 2026
Merged

Pr takeover 33240#33263
tjshiu merged 4 commits into
angular:mainfrom
tjshiu:pr-takeover-33240

Conversation

@tjshiu
Copy link
Copy Markdown
Contributor

@tjshiu tjshiu commented May 15, 2026

Addressed pnpm v11 strictness issues to fix the installation:

  • Placeholders: Resolved 0.0.0-NG errors by adding overrides and devDependencies pointing to the catalog version.
  • Scripts: Allowed trusted build scripts (like esbuild and re2) in pnpm-workspace.yaml to satisfy new security defaults.
  • Verified with a clean local installation.

angular-robot and others added 2 commits May 14, 2026 17:27
See associated pull request for more information.

Closes angular#33240 as a pr takeover
Address resolution failures for '0.0.0-NG' placeholders by adding overrides in the root package.json and adding missing devDependencies in sub-projects. Allow trusted build scripts in pnpm-workspace.yaml to satisfy pnpm v11 security defaults. Ensure a clean install can complete successfully.
@pullapprove pullapprove Bot requested review from crisbeto and wagnermaciel May 15, 2026 17:27
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label May 15, 2026
Address visibility violation in Bazel by adding components-examples to the visibility list in MODULE.bazel.
@alan-agius4 alan-agius4 force-pushed the pr-takeover-33240 branch 3 times, most recently from 8fcefb8 to 672bd49 Compare May 18, 2026 07:47
…o version 11.1.1

With pnpm 11 configuration is soley done via the workspace file.
@tjshiu tjshiu added target: patch This PR is targeted for the next patch release target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] action: merge The PR is ready for merge by the caretaker and removed target: patch This PR is targeted for the next patch release labels May 19, 2026
@tjshiu tjshiu merged commit e54c033 into angular:main May 19, 2026
33 checks passed
@tjshiu
Copy link
Copy Markdown
Contributor Author

tjshiu commented May 19, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants