fix(aria/menu): unable to set softDisabled#33265
Merged
Merged
Conversation
Fixes the following issues in the Aria menu: 1. The menu didn't have a `softDisabled` input. 2. The menu bar had a `softDisabled` input, but it was being ignored. Fixes angular#33262.
crisbeto
force-pushed
the
33262/aria-menu-soft-disabled
branch
from
3e92d66 to
3071ef6
Compare
ok7sai
approved these changes
May 16, 2026
crisbeto
added
action: merge
Member
Author
crisbeto
added a commit
that referenced
this pull request
May 16, 2026
|
Thank you for the swift fix, much appreciated. I see some properties on the MenuPattern defined, hardcoded and not exposed. I was wondering if this is intentional or also missed. Thanks again :) |
Member
Author
|
I think those were inherited from the list behavior and don't necessarily make sense to be configured in the menu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following issues in the Aria menu:
softDisabledinput.softDisabledinput, but it was being ignored.Fixes #33262.