fix(just-extend): prevent prototype pollution via dangerous keys#595
Open
abhu85 wants to merge 1 commit into
Open
fix(just-extend): prevent prototype pollution via dangerous keys#595abhu85 wants to merge 1 commit into
abhu85 wants to merge 1 commit into
Conversation
Block __proto__, constructor, and prototype keys during extend operations
to prevent prototype pollution attacks. Attackers could previously pollute
Object.prototype by constructing payloads like:
JSON.parse('{"__proto__":{"polluted":"yes"}}')
This fix skips dangerous keys in both shallow and deep extend modes.
Fixes angus-c#593, Fixes angus-c#594
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes critical prototype pollution vulnerability (CVE pending) in
just-extend@6.2.0.The
extend()function was vulnerable to prototype pollution attacks because it did not filter dangerous property names (__proto__,constructor,prototype) when iterating over source object keys. Attackers could polluteObject.prototypevia:Changes
__proto__,constructor, andprototypekeys in bothindex.cjsandindex.mjs__proto__pollution blocked (deep & shallow)constructor.prototypepollution blockedproto,_constructor) still workTest Results
All 1652 tests pass, including 4 new security-focused tests.
References
Fixes #593, Fixes #594
Before/After
{"__proto__":{"x":1}}{}.x === 1{}.x === undefined{constructor:{prototype:{x:1}}}