Skip to content

Add hour minute duration time picker and minor optimizations#9

Open
anhtuanmai wants to merge 3 commits intoanhaki:mainfrom
anhtuanmai:feat/hour-minute-duration
Open

Add hour minute duration time picker and minor optimizations#9
anhtuanmai wants to merge 3 commits intoanhaki:mainfrom
anhtuanmai:feat/hour-minute-duration

Conversation

@anhtuanmai
Copy link
Contributor

No description provided.

@anhaki
Copy link
Owner

anhaki commented Feb 8, 2026

I've cherry-picked the [Optimize Wheel.kt] one to fix func that was being called multiple time (great job, it's now in 1.1.6).

  • For the [Stabilize NumberWheel.kt text width] is causing the wheel with different character length overflow. Do we have reason for using this?
  • For [Stabilize NumberWheel.kt text width] do you think we can do better by make it less confusing by using data class e.g. Duration(hour: 4, minute: 30) instead of the total of minute?

@anhtuanmai
Copy link
Contributor Author

IMO, for Add PickHourMinuteDuration , the duration class make it a supplement class and it must handle the constraint such as minutes <= 60, just keep the maxDuration in minutes is simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants