feat(vault): add hide/unhide video vault feature with PIN lock#1745
Open
NarayanChetri wants to merge 1 commit into
Open
feat(vault): add hide/unhide video vault feature with PIN lock#1745NarayanChetri wants to merge 1 commit into
NarayanChetri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a vault feature that lets users hide videos behind a 4-digit PIN, keeping them out of the main library.
Fixes #1523
What's included ✨
Long-press the app title on the home screen to open the vault
Set a 4-digit PIN on first use
Hidden videos are only accessible from the vault
Vault gallery with playback, unhide, delete, sort, and multi-select
How hiding works ❓❔
Due to Android scoped storage restrictions, hiding a video works by copying it to the app's private storage and deleting the original via MediaStore. This unfortunately triggers the system's "do you want to delete this file?" confirmation popup, which makes user experience little bad.
If MANAGE_EXTERNAL_STORAGE is acceptable for this project, I can rework it to move files directly without that popup, making the experience much cleaner. Happy to do that if it fits the project's direction.
Known limitation⚠️
The delete confirmation during hide is a scoped storage side effect. Everything works correctly, just one extra tap for the user.
Open to any feedback — this is one of my first contributions so let me know if anything needs fixing!