Open
Conversation
82cc1d7 to
c1d1cfc
Compare
david-allison
requested changes
Dec 13, 2025
Member
david-allison
left a comment
There was a problem hiding this comment.
The first commit shouldn't have a 'refactor' message IMO - it's borderline
AnkiDroid/src/main/java/com/ichi2/anki/multimedia/audio/AudioRecordingController.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/test/java/com/ichi2/anki/recorder/AudioTimerTest.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/test/java/com/ichi2/anki/recorder/AudioTimerTest.kt
Outdated
Show resolved
Hide resolved
c1d1cfc to
1fbc85e
Compare
1fbc85e to
92f0bd8
Compare
- Replaces the legacy Handler/Runnable implementation with Kotlin Coroutines to improve timing accuracy, lifecycle safety, and code readability. - remove interface and use lambdas
92f0bd8 to
4c60e78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
I am preparing Audio timer to be used in notification i.e. allow update every 1s for notification as
msupdates are too much and Android ignore them, it also removes interfaces and uses modern lambdas to observe time and update it in UIFixes
NA
Approach
Replaces the legacy Handler/Runnable implementation with Kotlin Coroutines
How Has This Been Tested?
Pixel Fold API 36 and unit tests
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.