Merged
Conversation
I want to do a large refactoring, and confirming the defaults are unchanged will go a long way
david-allison
force-pushed
the
card-browser-menu-test
branch
from
9878dad to
2258a9c
Compare
5 tasks
mikehardy
reviewed
Jan 30, 2026
Comment on lines
+41
to
+56
| suspend fun withSplitPaneUiAsync(block: suspend () -> Unit) = withQualifierAsync("sw700dp", block) | ||
|
|
||
| suspend fun withQualifierAsync( | ||
| newQualifier: String, | ||
| block: suspend () -> Unit, | ||
| ) { | ||
| val qualifiers = RuntimeEnvironment.getQualifiers() | ||
| try { | ||
| Timber.d("Adding '$newQualifier' to qualifiers $qualifiers") | ||
| RuntimeEnvironment.setQualifiers("+$newQualifier") | ||
| block() | ||
| } finally { | ||
| Timber.d("Resetting qualifiers to $qualifiers") | ||
| RuntimeEnvironment.setQualifiers(qualifiers) | ||
| } | ||
| } |
mikehardy
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to do a large refactoring, and confirming the defaults are unchanged will go a long way in proving functionality is unchanged
For:
MenuProvider#20208How Has This Been Tested?
Test-only
Checklist