Skip to content

fix: card repositioning doesn't work for suspended card(s)#20316

Open
saifkaral wants to merge 5 commits intoankidroid:mainfrom
saifkaral:fix/card-reposition-suspended
Open

fix: card repositioning doesn't work for suspended card(s)#20316
saifkaral wants to merge 5 commits intoankidroid:mainfrom
saifkaral:fix/card-reposition-suspended

Conversation

@saifkaral
Copy link

@saifkaral saifkaral commented Feb 11, 2026

Purpose / Description

Previously if the user tried to reposition a suspended card or a group of suspended cards or a group of cards that includes one or more suspended cards the app gives them an error message "Only new cards can be repositioned".

Fixes

Approach

This fix now allows the user to freely reposition suspended cards given that theses cards weren't reviewed before.

How Has This Been Tested?

Tested by trying all the combinations I listed above and observe if the bug persists, also added a test case

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added the Review High Priority Request for high priority review label Mar 4, 2026
@david-allison
Copy link
Member

Could this discussion be moved to the linked issue:


Anki Desktop allows users to reposition cards which are already studied (having no effect).

We continue to differ from this functionality, and this implementation doesn't feel like it was discussed. Selecting all cards and repositioning may be perfectly valid.

The only case which is truly questionable is when all cards are not repositionable.

@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Mar 4, 2026
@saifkaral saifkaral force-pushed the fix/card-reposition-suspended branch from d720f1d to d07e168 Compare March 5, 2026 00:30
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, cheers! Thanks so much for the fast turnaround

@saifkaral saifkaral force-pushed the fix/card-reposition-suspended branch from d967717 to 3f98a40 Compare March 5, 2026 20:15
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent - one more round of feedback I think (mostly with the bad link to upstream)

Optional: I don't think the docs on sortCards were updated

@david-allison david-allison added this to the 2.24 release milestone Mar 5, 2026
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly excellent stuff, thanks!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge squash-merge A squash & force push is required. The PR author may do this to speed up the merge process. and removed Needs Author Reply Waiting for a reply from the original author labels Mar 5, 2026
@david-allison
Copy link
Member

It will be slightly easier for us to merge if you squash merge this to 1 commit + force push

Since it's your first PR, don't worry too much about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Second Approval Has one approval, one more approval to merge New contributor Review High Priority Request for high priority review squash-merge A squash & force push is required. The PR author may do this to speed up the merge process.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't reposition despite filtering only for new cards

2 participants