Skip to content

Refactor update layout structure#20353

Open
jatinfoujdar wants to merge 1 commit intoankidroid:mainfrom
jatinfoujdar:refactor-update-layout-structure
Open

Refactor update layout structure#20353
jatinfoujdar wants to merge 1 commit intoankidroid:mainfrom
jatinfoujdar:refactor-update-layout-structure

Conversation

@jatinfoujdar
Copy link

@jatinfoujdar jatinfoujdar commented Feb 22, 2026

Purpose / Description

This PR addresses multiple UI readability and clipping issues identified when using large system font sizes, as part of the umbrella issue #17100.

Fixes

Approach

The core strategy involved moving from fixed-height or single-line layouts to flexible, wrapping, and scrollable containers.

  1. Note Editor (Card Editor)
    File:

note_editor_fragment.xml
to prevent label/selector clipping.

How Has This Been Tested?

Configuration
Tested on Android Emulator (API 34) with maximum font scaling. All screens verified as readable and scrollable.

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • [ x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [ x] You have commented your code, particularly in hard-to-understand areas
  • [x ] You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner
Screenshot_20260223_163808 Screenshot_20260223_163914 Screenshot_20260223_164043 Screenshot_20260223_164316 Screenshot_20260223_164614

@welcome
Copy link

welcome bot commented Feb 22, 2026

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains extra unrelated changes(the first commit) which should be removed from the PR.

Also add images with the changed screens.

@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Feb 23, 2026
@jatinfoujdar jatinfoujdar force-pushed the refactor-update-layout-structure branch from 6e5df04 to ab461a3 Compare February 23, 2026 08:24
@jatinfoujdar
Copy link
Author

Hi @lukstbit , I have rebased the branch to remove the unrelated BackupManager changes. The PR now only contains the UI refactoring for #17100. I am also adding the requested screenshots now.

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR feels too big for a first contribution, could you split out one screeninto a new PR so we can quickly get it merged

Comment on lines +122 to +123
useWideViewPort = true
loadWithOverviewMode = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't appear to be in the screenshots, could you revert them, or explain why they're necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Author Reply Waiting for a reply from the original author Needs Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants