Skip to content

fix: Show red text if the tag already exists and disable the button #20368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PrathamDevX wants to merge 2 commits into
base: main
Choose a base branch
from
+47 −0
Open

fix: Show red text if the tag already exists and disable the button #20368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1955f3d
Browser: Show error and disable OK for duplicate tags
PrathamDevX Feb 27, 2026
255d980
Browser: show error and disable OK for duplicate tags
PrathamDevX Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/dialogs/tags/TagsDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import androidx.core.content.ContextCompat
import androidx.core.os.BundleCompat
import androidx.core.os.bundleOf
import androidx.core.view.isVisible
import androidx.core.widget.doAfterTextChanged
import androidx.fragment.app.viewModels
import androidx.lifecycle.flowWithLifecycle
import androidx.lifecycle.lifecycleScope
Expand Down Expand Up @@ -389,13 +390,58 @@ class TagsDialog : AnalyticsDialogFragment {
addTag(input.toString())
d?.dismiss()
}

val inputET = addTagDialog.getInputField()

inputET.filters = arrayOf(addTagFilter)

if (!prefixTag.isNullOrEmpty()) {
// utilize the addTagFilter to append '::' properly by appending a space to prefixTag
Copy link
Contributor

@criticalAY criticalAY Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing the comment?

Copy link
Contributor Author

@PrathamDevX PrathamDevX Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that wasn’t intentional. I’ll add it back.

inputET.setText("$prefixTag ")
}

inputET.moveCursorToEnd()

val positiveButton =
addTagDialog.getButton(AlertDialog.BUTTON_POSITIVE)

positiveButton.isEnabled = false

val textInputLayout =
inputET.parent?.parent
as? com.google.android.material.textfield.TextInputLayout

inputET.doAfterTextChanged { text ->

val rawTag = text?.toString()?.trim()

if (rawTag.isNullOrEmpty()) {
textInputLayout?.error = null
positiveButton.isEnabled = false
return@doAfterTextChanged
}

lifecycleScope.launch {
val tags = viewModel.tags.await()

val normalized =
TagsUtil.getUniformedTag(rawTag)

val exists =
tags.contains(normalized)

if (exists) {
textInputLayout?.error =
getString(R.string.tag_already_exists)

positiveButton.isEnabled = false
} else {
textInputLayout?.error = null

positiveButton.isEnabled = true
}
}
}
addTagDialog.show()
}

Expand Down
1 change: 1 addition & 0 deletions AnkiDroid/src/main/res/values/02-strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@
<string name="dyn_deck_desc">This is a special deck for studying outside of the normal schedule. Cards will be automatically returned to their original decks after you review them. Deleting this deck from the deck list will return all remaining cards to their original deck.</string>
<string name="tag_editor_add_feedback">Touch “%2$s” to confirm adding “%1$s”</string>
<string name="tag_editor_add_feedback_existing">Existing tag “%1$s” selected</string>
<string name="tag_already_exists">Tag already exists</string>
<!-- Time spans -->

<!-- Currently only used if exporting APKG fails -->
Expand Down
Loading