Skip to content

fix: Sync no longer on leave study/background #20369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Giyutomioka-SS wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −0
Open

fix: Sync no longer on leave study/background #20369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0f4e6d
fix: prevent duplicate startup sync on resume
Giyutomioka-SS Feb 27, 2026
508117f
consume startup response in ViewModel
Giyutomioka-SS Mar 4, 2026
4a70409
add activity test for startup response clear after handle
Giyutomioka-SS Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,7 @@ open class DeckPicker :
}

is StartupResponse.Success -> {
viewModel.flowOfStartupResponse.value = null // Prevent duplicate startup on re-resume
showStartupScreensAndDialogs(sharedPrefs(), 0)

if (tryShowStudyOptionsPanel()) {
Expand Down
11 changes: 11 additions & 0 deletions AnkiDroid/src/test/java/com/ichi2/anki/DeckPickerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,17 @@ class DeckPickerTest : RobolectricTest() {
)
}

@Test
fun `startup response is cleared after handling so it does not re-run on resume`() =
deckPicker {
ShadowLooper.runUiThreadTasksIncludingDelayedTasks()
assertThat(
"startup response cleared after handling so it does not re-run on resume",
viewModel.flowOfStartupResponse.value,
nullValue(),
)
}

/**
* Emulates a null collection and a `BackendDbLockedException`
*
Expand Down
Loading