Skip to content

Fix(Whiteboard): Side System Gesture Exclusion#20375

Open
LUwUcifer wants to merge 1 commit intoankidroid:mainfrom
LUwUcifer:whiteboard-gesture
Open

Fix(Whiteboard): Side System Gesture Exclusion#20375
LUwUcifer wants to merge 1 commit intoankidroid:mainfrom
LUwUcifer:whiteboard-gesture

Conversation

@LUwUcifer
Copy link
Contributor

Purpose / Description

When whiteboard toolbar is docked to the sides and collapsed, swiping right will not cause the app to exit

Fixes

Approach

Calls systemGestureExclusionRects function within an overriden onLayout function within the whiteboardToolbar to include the whiteboard as an excluded Rect, it should be noted that since the toolbar has a starting margin of 8dp, swiping in that area would still cause the screen to exit

How Has This Been Tested?

Tested on a local device as well as an Emulated Medium Phone API 36.1

Learning (optional, can help others)

Previous usages of the function setSystemGestureExclusionRects in other repositories on github heavily influenced the written code

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

david-allison

This comment was marked as resolved.

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Mar 4, 2026
@LUwUcifer LUwUcifer closed this Mar 5, 2026
@LUwUcifer LUwUcifer force-pushed the whiteboard-gesture branch from 0614dec to 7a7f9ae Compare March 5, 2026 10:05
@LUwUcifer

This comment was marked as resolved.

@LUwUcifer LUwUcifer reopened this Mar 5, 2026
@LUwUcifer

This comment was marked as resolved.

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author Needs Review labels Mar 5, 2026
@david-allison david-allison requested a review from BrayanDSO March 5, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Second Approval Has one approval, one more approval to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New study screen] Make whiteboard Hide toolbar feature compatible with system navigation gestures

2 participants