Fix(Whiteboard): Side System Gesture Exclusion#20375
Open
LUwUcifer wants to merge 1 commit intoankidroid:mainfrom
Open
Fix(Whiteboard): Side System Gesture Exclusion#20375LUwUcifer wants to merge 1 commit intoankidroid:mainfrom
LUwUcifer wants to merge 1 commit intoankidroid:mainfrom
Conversation
0614dec to
7a7f9ae
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
When whiteboard toolbar is docked to the sides and collapsed, swiping right will not cause the app to exit
Fixes
Hide toolbarfeature compatible with system navigation gestures #20346Approach
Calls systemGestureExclusionRects function within an overriden onLayout function within the whiteboardToolbar to include the whiteboard as an excluded Rect, it should be noted that since the toolbar has a starting margin of 8dp, swiping in that area would still cause the screen to exit
How Has This Been Tested?
Tested on a local device as well as an Emulated Medium Phone API 36.1
Learning (optional, can help others)
Previous usages of the function setSystemGestureExclusionRects in other repositories on github heavily influenced the written code
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.