Skip to content

fix: stabilise description dialog shaking #20376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HS0204 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

fix: stabilise description dialog shaking #20376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/dialogs/EditDeckDescriptionDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import androidx.appcompat.app.AlertDialog
import androidx.core.os.bundleOf
import androidx.core.view.ViewCompat
import androidx.core.view.WindowInsetsCompat
import androidx.core.widget.doAfterTextChanged
import androidx.core.widget.doOnTextChanged
import androidx.fragment.app.DialogFragment
import androidx.fragment.app.viewModels
Expand Down Expand Up @@ -132,6 +133,14 @@ class EditDeckDescriptionDialog : DialogFragment() {
}
}

with(binding.deckDescriptionInput) {
doAfterTextChanged {
// avoid an additional layout pass in the same frame as
// TextInputLayout's internal requestLayout(), which causes shaking
(this.parent as? View)?.post { requestLayout() }
}
}

setupFlows()
}

Expand Down
Loading