Refactor NoteEditor to use changeNoteType dialog

[Haz3-jolt]

Purpose / Description

Refactors the noteEditor to use changeNoteTypeDialog and deprecates the old implementation

Fixes

• Fixes Refactor NoteEditor to use Change Note Type Dialog #20236

Approach

• This PR consists of three commits:

1. Refactoring NoteEditor to use changeNoteType dialog
2. Removing the old implementation code
3. Minor warning fixups

How Has This Been Tested?

Pixel Tablet (API 36)
Before:
Screen_recording_20260303_140341.webm

After
Screen_recording_20260303_140105.webm

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[Haz3-jolt]

Does the note editor need to be closed when changing the note type? Would that mean that we can no longer change the note type in the "Add" screen?

Nope! This is only when the noteEditor is opened in edit mode :)

Screen_recording_20260303_142948.webm

[Haz3-jolt]

@david-allison can you restart the lint job I ran ./gradlew ktlintCheck and ./gradlew ktlintFormat locally and couldn't find anything. The job is talking about three resources being unused, but they are actually being used

[david-allison]

See: https://github.com/ankidroid/Anki-Android/tree/main/.github/workflows#quality-checks

gh pr checkout --force 20377
./gradlew lintPlayDebug :api:lintDebug :libanki:lintDebug ktLintCheck lintVitalFullRelease lint-rules:test --daemon

  /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values/01-core.xml:131: Error: The resource R.string.nothing appears to be unused [UnusedResources]
      <string name="nothing">Nothing</string>
              ~~~~~~~~~~~~~~
  /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values/02-strings.xml:111: Error: The resource R.string.confirm_map_cards_to_nothing appears to be unused [UnusedResources]
      <string name="confirm_map_cards_to_nothing">Any cards mapped to nothing will be deleted. If a note has no remaining cards, it will be lost. Are you sure you want to continue?</string>
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/drawable/ic_import_export.xml:1: Error: The resource R.drawable.ic_import_export appears to be unused [UnusedResources]
  <vector xmlns:android="http://schemas.android.com/apk/res/android"

[Haz3-jolt]

@david-allison flaky windows run?

[david-allison]

Beautiful! LGTM