build: use standardized Gradle Daemon toolchain [JetBrainsRuntime/21]#20383
Open
david-allison wants to merge 2 commits intoankidroid:mainfrom
Open
build: use standardized Gradle Daemon toolchain [JetBrainsRuntime/21]#20383david-allison wants to merge 2 commits intoankidroid:mainfrom
david-allison wants to merge 2 commits intoankidroid:mainfrom
Conversation
using Gradle Daemon JVM Criteria: [JetBrainsRuntime/21] This change was performed by Android Studio https://developer.android.com/studio/releases/past-releases/as-panda-1-release-notes#daemon-jvm-criteria I committed `gradle-daemon-jvm.properties` as it was done so in gradle: https://github.com/gradle/gradle/commits/master/gradle/gradle-daemon-jvm.properties This file standardizes the project, so invocations will use: * https://github.com/JetBrains/JetBrainsRuntime * source: https://api.foojay.io/disco/v3.0/distributions * toolchainVersion: 21 > Projects using Daemon toolchain allow builds to automatically detect > installed toolchains given the defined JVM criteria or download a compatible > one if cannot be found locally. > In addition, using the Daemon toolchain aligns the selection between CLI and > IDE, avoiding spawning multiple Daemons improving performance but also makes > it simple to handle the required toolchain on different machines. My conclusions: * Standardizing the toolchain should help onboarding. * Using the JetBrains runtime seems like a sensible JVM: https://github.com/JetBrains/JetBrainsRuntime * If there are issues, we can revert this with little fallout Glossary: foojay: Friends of OpenJDK Disco: Discovery API Docs: https://developer.android.com/studio/releases/past-releases/as-panda-1-release-notes#daemon-jvm-criteria https://api.foojay.io/swagger-ui/ https://plugins.gradle.org/plugin/org.gradle.toolchains.foojay-resolver-convention https://docs.gradle.org/current/userguide/gradle_daemon.html#daemon_jvm_criteria Fixes 20382
* Fix 'foojay' being a typo * Friends of OpenJDK: https://foojay.io/ * Document plugin Issue 20382
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Android Studio proposed doing this, aligning the CLI and in-IDE invocations of gradle, and aligning the toolchain across developer machines.
Changelog with more details: https://developer.android.com/studio/releases/past-releases/as-panda-1-release-notes#daemon-jvm-criteria
Fixes
Approach
How Has This Been Tested?
Trusting CI, project appears to still build and run
Learning
Checklist