Skip to content

fix(grade-now): handle binding when view is reused #20390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-allison wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −10
Open

fix(grade-now): handle binding when view is reused #20390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions AnkiDroid/src/main/java/com/ichi2/anki/dialogs/GradeNowDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,16 +104,21 @@ private class GradeNowListAdapter(
position: Int,
convertView: View?,
parent: ViewGroup,
): View =
convertView ?: GradeNowListItemBinding
.inflate(LayoutInflater.from(context), parent, false)
.also { binding ->
val grade = getItem(position)!!
binding.gradeTextView.apply {
text = grade.getLabel()
setCompoundDrawablesRelativeWithIntrinsicBoundsKt(start = grade.iconRes)
}
}.root
): View {
val binding =
if (convertView != null) {
GradeNowListItemBinding.bind(convertView)
} else {
GradeNowListItemBinding.inflate(LayoutInflater.from(context), parent, false)
}

val grade = getItem(position)!!
binding.gradeTextView.apply {
text = grade.getLabel()
setCompoundDrawablesRelativeWithIntrinsicBoundsKt(start = grade.iconRes)
}
return binding.root
}
}

private enum class Grade(
Expand Down
Loading