fix(browser): SearchView fragment state transitions [dev only]#20399
Open
david-allison wants to merge 1 commit intoankidroid:mainfrom
Open
fix(browser): SearchView fragment state transitions [dev only]#20399david-allison wants to merge 1 commit intoankidroid:mainfrom
david-allison wants to merge 1 commit intoankidroid:mainfrom
Conversation
david-allison
added
the
Needs Second Approval
david-allison
changed the title
Previously if opening the 'advanced' search, the content of the 'standard' search overlapped with it This ensures that a tag is used when attaching the 'standard' search so it can be hidden properly Issue 18709
david-allison
force-pushed
the
18709-fix-standard-search-overlap
branch
from
1c6972f to
2fb07f5
Compare
david-allison
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Previously if opening the 'advanced' search, the content of the 'standard' search overlapped with it
This ensures that a tag is used when attaching the 'standard' search so it can be hidden properly
Fixes
Approach
Always use the tag to create/restore the fragment
How Has This Been Tested?
Personal
browser-advanced-morebranchContent no longer overlaps between the two fragments
Checklist