fix(ExportDialogFragment.kt) : TransactionTooLargeException #20984
Merged
Conversation
david-allison
requested changes
May 7, 2026
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
This doesn't handle the case where the IdsFile is deleted, so getIds() fails
david-allison
added
the
Needs Author Reply
Alok-Silswal
commented
May 12, 2026
Contributor
Author
Alok-Silswal
left a comment
Alok-Silswal
left a comment
There was a problem hiding this comment.
All the required changes done!
david-allison
approved these changes
May 12, 2026
david-allison
added
Needs Second Approval
Alok-Silswal
force-pushed
the
fix-exportdialog-idsfile
branch
from
580f6bb to
1a3441c
Compare
Alok-Silswal
force-pushed
the
fix-exportdialog-idsfile
branch
from
1a3441c to
df1d4f4
Compare
Contributor
Author
|
I inlined code but when I pushed them they are spreading to multiple lines. I suspect klint is auto-formatting code when I am commiting changes. Tried this twice. |
Contributor
|
LGTM! |
5 tasks
BrayanDSO
approved these changes
May 16, 2026
BrayanDSO
added
Pending Merge
github-actions
Bot
removed
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Export Dialog crashed when >60k browsed cards are selected and the user puts the app in the background.
One small refactor in
FindAndReplaceDialogFragment.ktthat was modified to use new extension method for cleanup due to recurring code.Fixes
Approach
Imitated the approach used in
FindAndReplaceDialogFragment.ktto deal with this issue by using classIdsFilerather than usingBundle, which was overflowing when the capacity exceeded, thereby causing the crash.Used extension method for cleanup operation.
How Has This Been Tested?
Tested on my phone (Android 14, Xiaomi / HyperOS) using a debug build.
Both these observations have been tested. Video attached as evidence.
Learning (optional, can help others)
In
ExportDialogFragment.kt, there is a scope for code refactoring and cleanup. This would have shrunk this PR by some lines. But I intentionally avioided it in this PR as it do not fit in this scope.Export_dialog_app_reopen_issue_resolved.mp4
Checklist
Please, go through these checks before submitting the PR.