Skip to content

refactor(card-browser): BrowserDestination#21027

Merged
BrayanDSO merged 2 commits into
ankidroid:mainfrom
david-allison:browser-refactor
May 16, 2026
Merged

refactor(card-browser): BrowserDestination#21027
BrayanDSO merged 2 commits into
ankidroid:mainfrom
david-allison:browser-refactor

Conversation

@david-allison
Copy link
Copy Markdown
Member

@david-allison david-allison commented May 12, 2026 •
edited
Loading

Note

Assisted-by: Claude Opus 4.7 - mostly tests

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison mentioned this pull request May 12, 2026
Open
5 tasks
Giyutomioka-SS
Giyutomioka-SS reviewed May 15, 2026
View reviewed changes
Comment thread AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserViewModel.kt Outdated
@david-allison
refactor(card-browser): initial selected deck
9b82edb 
This should be a responsibility of the browser, not the destination

Assisted-by: Claude Opus 4.7
@david-allison
refactor(card-browser): browser destination
b8ec926 
* ToCard => ScrollToCard
* Move EXTRA_CARD_ID_KEY to ViewModel

This should be a responsibility of the browser, not the destination

Assisted-by: Claude Opus 4.7 - all
@BrayanDSO BrayanDSO added this pull request to the merge queue May 16, 2026
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels May 16, 2026
Merged via the queue into ankidroid:main with commit c99b6b5 May 16, 2026
19 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone May 16, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 16, 2026
@david-allison david-allison deleted the browser-refactor branch May 16, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrayanDSO BrayanDSO BrayanDSO approved these changes

+1 more reviewer

@Giyutomioka-SS Giyutomioka-SS Giyutomioka-SS left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.25 release

Development

Successfully merging this pull request may close these issues.

3 participants

@david-allison @BrayanDSO @Giyutomioka-SS