Skip to content

chore(architecture): add anki-common module skeleton#21028

Merged
criticalAY merged 1 commit into
ankidroid:mainfrom
david-allison:anki-common
May 12, 2026
Merged

chore(architecture): add anki-common module skeleton#21028
criticalAY merged 1 commit into
ankidroid:mainfrom
david-allison:anki-common

Conversation

@david-allison
Copy link
Copy Markdown
Member

@david-allison david-allison commented May 12, 2026

Note

Assisted-by: Claude Opus 4.7 - almost all

Purpose / Description

This is designed for common files which also depend on libanki, therefore cannot be inside common or common:android.

Initially, this is to implement the Destination concern: navigation between Activities needs DeckId (can't be in :common), and wouldn't be able to have circular dependencies, so couldn't live in feature modules when we move to them

Fixes

Approach

See README.md

For example, CollectionManager should live here:

  • Not in libanki
  • libanki dependency
  • Common code

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

This is designed for common files which also depend on libanki,
therefore cannot be inside `common` or `common:android`.

Initially, this is to implement the `Destination` concern: navigation
between Activities needs `DeckId` (can't be in `:common`), and wouldn't
be able to have circular dependencies when we move to feature modules

Assisted-by: Claude Opus 4.7 - all
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 12, 2026
@criticalAY criticalAY added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 12, 2026
@criticalAY criticalAY enabled auto-merge May 12, 2026 10:48
@criticalAY criticalAY added this pull request to the merge queue May 12, 2026
Merged via the queue into ankidroid:main with commit 895377c May 12, 2026
22 of 23 checks passed
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 12, 2026
@github-actions github-actions Bot added this to the 2.25 release milestone May 12, 2026
@david-allison david-allison deleted the anki-common branch May 12, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants