Integrate Search Results with Monaco Editor Navigation#9
Open
rachit-goyal1071 wants to merge 3 commits intoankurg132:mainfrom
Open
Integrate Search Results with Monaco Editor Navigation#9rachit-goyal1071 wants to merge 3 commits intoankurg132:mainfrom
rachit-goyal1071 wants to merge 3 commits intoankurg132:mainfrom
Conversation
Contributor
Author
|
Hey @ankurg132 is there any update on PR any changes required or any othr issue is there please do tell me.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate Search Results with Monaco Editor Navigation
Related Issue
Closes / Addresses: #7
Summary
This PR adds editor-side integration between the global search feature and
flutter_monaco, making search results actionable inside the editor.It aligns search behavior with standard IDE expectations by ensuring that interacting with a search result correctly navigates, reveals, highlights, and focuses the Monaco editor.
What This PR Covers
Navigate to Match
Reveal Match in Viewport
Highlight Matched Range
Editor Focus Handling
Third-Party Monaco Patch
This PR introduces a small third-party / patched Monaco layer to bridge gaps in the
current
flutter_monacoAPI.Why this is needed
The public
flutter_monacoAPIs do not fully expose:These capabilities are required to make search results fully actionable and
IDE-consistent.
What the patch does
Future direction
This layer is intentionally minimal and isolated. If
flutter_monacoaddsequivalent APIs upstream, this patch can be removed or simplified.
Implementation Notes
flutter_monacocontroller APIs where availableScope Clarification
Context
This PR is raised following discussion in issue #7.
The prior conversation is referenced only for background and does not affect the
implementation scope.